-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Youtube settings
patch failed to resolve ThemeSetterAppFingerprint
#2476
Comments
I can confirm I'm getting this as well. It seems quite a few patches depend on this missing What's stranger is that it exists in the Initializing installer
Creating working directory
Copying original apk
Unpacking input apk
Reading dex files
Decoding AndroidManifest.xml only, because resources are not needed
Merging integrations
Deleting existing resource cache directory
Decoding resources
Applied custom-branding
Failed to apply general-ads: 'general-ads' depends on 'GeneralAdsResourcePatch' but the following error was raised: 'GeneralAdsResourcePatch' depends on 'settings' but the following error was raised: Failed to resolve ThemeSetterAppFingerprint
Failed to apply hdr-auto-brightness: 'hdr-auto-brightness' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied premium-heading
Failed to apply return-youtube-dislike: 'return-youtube-dislike' depends on 'return-youtube-dislike-resource-patch' but the following error was raised: 'return-youtube-dislike-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply settings: 'settings' did not succeed previously
Failed to apply sponsorblock: 'sponsorblock' depends on 'sponsorblock-resource-patch' but the following error was raised: 'sponsorblock-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Failed to apply swipe-controls: 'swipe-controls' depends on 'swipe-controls-resource-patch' but the following error was raised: 'swipe-controls-resource-patch' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Applied theme
Failed to apply video-ads: 'video-ads' depends on 'settings' but the following error was raised: 'settings' did not succeed previously
Repacking patched apk
Compiling resources
Writing modified dex files
Finished! |
It doesn't exist in the json. |
Workaround found: uninstall and reinstall Revanced Manager, and try patching again. The only problem is that the |
So, new behaviors, if I give root access to Revanced Manager, it fails to patch, if I do not, then it succeeds, but cannot install(For obvious reasons) |
This actually helps. But I got a walkarownd to install as root. First revoke root access of ReVanced then select the patches and start patching. And after finishing patch before install enable root access and than install. Works like a charm |
The patching process happens regardless of root. Reason why you can also patch on other devices with the CLI instead of directly on your phone. |
It should be like this but I can confirm revoking root access makes it so the patching succeeds. I tested it several times and it's definitely that. Edit: though I still can't manage to install it successfully afterwards. |
That would be weird because the patching process has nothing to do with root or not. Root is first used when installing/mounting. |
I'm use microg patch(no need for root, but I gave revanced manager root access), and facing the same problem. Just use the workaround mikk150 and FahimAnayet mentioned above: revoke root access to make a successful patch. Though the revanced manager can not install the APK file, there is an option on the left top menu to allow the patched APK to be exported. Then I just opened a file manager to install the patched APK file. might be helpful for root patches. |
I have the same error when using revanced-cli for patching Steps to reproduce Relevant log output
|
These are not compatible versions by the patches, check the compatible versions. |
Is there any fix for this? |
Patch compatible versions |
This comment was marked as spam.
This comment was marked as spam.
Using a non compatible version is unknown territory, and the expected outcome is failure. For patching a compatible app version, try:
|
I did that, even just applying the microg patch only with youtube at correct version and revanced stock gives the same error. |
If that is really the case it's very weird. Root or not is first required at installing the app. At no time root is required for patching applications. |
should we move the issue to the app repo? |
Dunno, it kinda belongs to both. |
i can confirm this problem exist on lastest 0.0.57 with patch 2.166.0 edit: im running android 13 |
I was facing this issue today (non-rooted Pixel 7 Pro on Android 13) when trying to patch the 18.05.40 version of YouTube. After upgrading my stock YouTube app from 17.x to 18.05.40, the issue went away and patching worked properly. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
If this is still a problem, please open a new issue. |
Type
Error while patching
Bug description
Patching youtube with patches that depend on patch
settings
fails withFailed to resolve ThemeSetterAppFingerprint
Steps to reproduce
v17.49.37
General Adds
Patch
Relevant log output
Screenshots or videos
No response
Solution
No response
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: