Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Videos not loading #2483

Closed
3 tasks done
MrMikeJJ opened this issue Nov 5, 2022 · 23 comments
Closed
3 tasks done

bug: Videos not loading #2483

MrMikeJJ opened this issue Nov 5, 2022 · 23 comments
Labels
Bug report Something isn't working

Comments

@MrMikeJJ
Copy link

MrMikeJJ commented Nov 5, 2022

Type

Error at runtime

Bug description

The same as #2484 but i cannot reopen that one.
The fix put in for #2484 seems to have helped a lot, but the issue still happens just less frequently.

After watching a few videos, it then gets stuck loading the video indefinitely.
You can work around this buy skipping to the end of the video then using replay to restart playback.

Steps to reproduce

  1. Live in the UK / connect to UK VPN server
  2. Try playing multiple videos
  3. Video will get stuck loading

Relevant log output

n/a

Screenshots or videos

No response

Solution

You can work around this buy skipping to the end of the video then using replay to restart playback.

Additional context

Not sure if it is related, but occasionally after using the skip to the end work around, the video will display the loading circle all the way through the video (while still playing).

This happening with the setting in "ReVanced -> Miscellaneous -> Fix video playback issues" enabled.

I tried updating to YouTube 17.43.36 but the issue persists.

Versions:
Android 8
Patched YouTube 17.43.36
Revanced Manager 0.0.39
Revanced Patches 2.102.1
Vanced microG 0.2.24.220220

Patches installed:
Custom Branding
General Ads
MicroG Support
Minimized Playback
Theme
Video Ads

This issue is assumed to be caused by MicroG: microg/GmsCore#1870.

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@MrMikeJJ MrMikeJJ added the Bug report Something isn't working label Nov 5, 2022
@oSumAtrIX
Copy link
Member

Please attach a recording.

@oSumAtrIX oSumAtrIX added the Waiting on author Further information is requested label Nov 5, 2022
@MrMikeJJ
Copy link
Author

MrMikeJJ commented Nov 5, 2022

Attached video.

XRecorder_05112022_143328.1.mp4

@oSumAtrIX
Copy link
Member

Can you record if this happens on multiple videos?

@MrMikeJJ
Copy link
Author

MrMikeJJ commented Nov 5, 2022

Happens 4 times on the attached clip.

Also on the 3rd one it happens on, you can see something strange (around 1m53s). It looks like it rewinds, even though i wasn't touching the screen at the time. (never seen it do that before, hence why i am mentioning it).

XRecorder_05112022_145644.0.mp4

@oSumAtrIX
Copy link
Member

I can not reproduce this on my end on an account where this issue is present without applying the fix. To reproduce I would need access to the account to test the issue on.

@oSumAtrIX
Copy link
Member

Seems like commit e756fac failed. After a fix and a release for it, the issue should be solved

@MrMikeJJ
Copy link
Author

MrMikeJJ commented Nov 7, 2022

With patches v2.104.0 it has massively improved, thank you.

But not totally fixed. It still happens occasionally, but only on the first video played after Revanced is opened.

@edegaudenzi
Copy link

Problem persists in exactly same modalities here, with the only exception that in my case it happens in all the videos: played and previewed.

My workaround is being connected to a VPN (nordvpn) pointing outside the UK, for example Paris or Milan.

LineageOS 18.1 (Android 11)
YouTube ReVanced non rooted - MicroG support

@bosbode
Copy link

bosbode commented Jan 18, 2023

I'm experiencing this problem as well in the Netherlands. As of today.

@oSumAtrIX
Copy link
Member

Changes are rolled out to multiple countries.

@LisoUseInAIKyrios
Copy link
Contributor

Try going into ReVanced settings and turning off all switches (including hide advertising). Then ReVanced should behave exactly the same as stock YouTube (including showing ads).

After doing this, is the issue still present?

@oSumAtrIX
Copy link
Member

This is not a ReVanced specific issue. Any client mod will cause this issue. This does not happen on mounted variant. Signature or package name is checked and server returns 403 on /videoplayback. The check can be outside of the app itself in GMS for example (or in non root variant in MicroG) or inside the app. I already spoofed every getPackageInfo call in YouTube but that did not help either, it is known that there is other ways to get the signature or package name (for example via context.getPackageName which i havent tried spoofing yet), or it was done in GMS/MicroG (which I havent looked into much either). In any case, this issue can be fixed by spoofing the signature and package name at some place properly.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Jan 19, 2023

Would be useful if someone with the issue tried using a root installation of ReVanced, and confirmed the issue is not present.

@oSumAtrIX
Copy link
Member

@LisoUseInAIKyrios I am able to reproduce in my dev env and can confirm that the root variant does not have this issue, hence why my conclusions on signature and package name.

@oSumAtrIX oSumAtrIX reopened this Jan 19, 2023
@oSumAtrIX oSumAtrIX changed the title bug: Videos not reliably loading for UK YouTube users bug: Videos not loading Jan 19, 2023
@Besix2

This comment was marked as spam.

@RaphiMC

This comment was marked as spam.

@cboehm-it

This comment was marked as spam.

@oSumAtrIX oSumAtrIX removed the Waiting on author Further information is requested label Jan 24, 2023
@Besix2

This comment was marked as spam.

@ILoveOpenSourceApplications
Copy link
Contributor

This issue is related to microg and not related to ReVanced YouTube. So closing this as of now.

@senposage
Copy link

senposage commented Feb 27, 2023

Note: the workaround does not work

as a work around try disabling Push nofications and cloud messaging
it looks like this is how google is detecting the vanced/microgms.

it seems like there is some kind of timeout on whatever restiction they are using when vanced is detected as well switching accounts and using the other account for awhile seems to unrestrict the other account allowing video to play

@oSumAtrIX
Copy link
Member

RE: microg/GmsCore#1870

@ReVanced ReVanced locked as resolved and limited conversation to collaborators Feb 27, 2023
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Mar 2, 2023

Would it be easy to create a patch that detects the condition (detect 403 status code)?

And then show the user a dialog that informs them what is going on, and give suggestions on how to fix (use incognito mode, change YouTube accounts, use VPN, install root ReVanced, etc)?

It would go a long way to help users figure out what to do.

@oSumAtrIX
Copy link
Member

An exception is thrown at a certain place, so yeah, it's feasible

@oSumAtrIX oSumAtrIX reopened this Dec 16, 2023
@ReVanced ReVanced unlocked this conversation Dec 16, 2023
@oSumAtrIX oSumAtrIX transferred this issue from ReVanced/revanced-patches-template Dec 16, 2023
@ReVanced ReVanced locked and limited conversation to collaborators Dec 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants