bug(Twitch): Patches cannot be applied

[LizenzFass78851]

Bug description

I'm trying to patch Twitch (in this example version 16.9.1) with the latest revanced patches (v4.0.1) and the latest revanced cli (v4.4.0) but it doesn't work because errors are thrown out.

Error logs

INFORMATION: Loading patches 
INFORMATION: Decoding app manifest 
INFORMATION: Predictive back gesture excluded 
INFORMATION: Remove screenshot restriction excluded 
INFORMATION: Spoof SIM country excluded 
INFORMATION: Enable Android debugging excluded 
INFORMATION: Override certificate pinning excluded 
INFORMATION: Change package name excluded 
INFORMATION: Export all activities excluded 
INFORMATION: Spoof Wi-Fi connection excluded 
INFORMATION: Remove screen capture restriction excluded 
INFORMATION: Debug mode excluded 
INFORMATION: Setting patch options 
INFORMATION: Merging integrations 
INFORMATION: Deleting existing resource cache directory 
INFORMATION: Decoding resources 
INFORMATION: Executing patches 
INFORMATION: Auto claim channel points succeeded 
INFORMATION: Block audio ads succeeded 
INFORMATION: Block embedded ads succeeded 
INFORMATION: Block video ads succeeded 
INFORMATION: Show deleted messages succeeded 
INFORMATION: Settings succeeded 
INFORMATION: Compiling patched dex files 
INFORMATION: Compiled classes.dex 
INFORMATION: Compiled classes2.dex 
INFORMATION: Compiled classes3.dex 
INFORMATION: Compiled classes4.dex 
INFORMATION: Compiled classes5.dex 
INFORMATION: Compiled classes6.dex 
INFORMATION: Compiled classes7.dex 
INFORMATION: Compiled classes8.dex 
INFORMATION: Compiled classes9.dex 
INFORMATION: Compiled classes10.dex 
INFORMATION: Compiled classes11.dex 
INFORMATION: Compiled classes12.dex 
INFORMATION: Compiling modified resources 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_misc_screen_summary (aka tv.twitch.android.app:string/revanced_misc_screen_summary) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_misc_screen_title (aka tv.twitch.android.app:string/revanced_misc_screen_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_other_category_title (aka tv.twitch.android.app:string/revanced_other_category_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_debug_summary_off (aka tv.twitch.android.app:string/revanced_debug_summary_off) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_debug_summary_on (aka tv.twitch.android.app:string/revanced_debug_summary_on) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_debug_title (aka tv.twitch.android.app:string/revanced_debug_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_chat_screen_summary (aka tv.twitch.android.app:string/revanced_chat_screen_summary) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_chat_screen_title (aka tv.twitch.android.app:string/revanced_chat_screen_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_general_category_title (aka tv.twitch.android.app:string/revanced_general_category_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource array/revanced_show_deleted_messages_entries (aka tv.twitch.android.app:array/revanced_show_deleted_messages_entries) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource array/revanced_show_deleted_messages_entry_values (aka tv.twitch.android.app:array/revanced_show_deleted_messages_entry_values) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_ads_screen_summary (aka tv.twitch.android.app:string/revanced_ads_screen_summary) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_ads_screen_title (aka tv.twitch.android.app:string/revanced_ads_screen_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_client_ads_category_title (aka tv.twitch.android.app:string/revanced_client_ads_category_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_surestream_ads_category_title (aka tv.twitch.android.app:string/revanced_surestream_ads_category_title) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource array/revanced_block_embedded_ads_entries (aka tv.twitch.android.app:array/revanced_block_embedded_ads_entries) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource array/revanced_block_embedded_ads_entry_values (aka tv.twitch.android.app:array/revanced_block_embedded_ads_entry_values) not found. 
WARNUNG: /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/res/xml/revanced_prefs.xml:2: error: resource string/revanced_block_embedded_ads_summary (aka tv.twitch.android.app:string/revanced_block_embedded_ads_summary) not found. 
WARNUNG: error: failed linking file resources. 
brut.androlib.exceptions.AndrolibException: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_79426848982417580091369358775099742045.tmp, link, -o, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 21, --target-sdk-version, 33, --version-code, 1609016, --version-name, 16.9.1, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /tmp/APKTOOL17017271800784647292.tmp, -0, arsc, -I, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/1.apk, --manifest, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/AndroidManifest.xml, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/build/resources.zip]
	at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:246)
	at brut.androlib.AaptInvoker.invokeAapt(AaptInvoker.java:391)
	at app.revanced.patcher.data.ResourceContext.get(ResourceContext.kt:128)
	at app.revanced.patcher.Patcher.get(Patcher.kt:265)
	at app.revanced.cli.command.PatchCommand.run(PatchCommand.kt:301)
	at picocli.CommandLine.executeUserObject(CommandLine.java:2026)
	at picocli.CommandLine.access$1500(CommandLine.java:148)
	at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
	at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
	at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
	at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
	at picocli.CommandLine.execute(CommandLine.java:2170)
	at app.revanced.cli.command.MainCommandKt.main(MainCommand.kt:12)
Caused by: brut.common.BrutException: could not exec (exit code = 1): [/tmp/brut_util_Jar_79426848982417580091369358775099742045.tmp, link, -o, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/aapt_temp_file, --package-id, 127, --min-sdk-version, 21, --target-sdk-version, 33, --version-code, 1609016, --version-name, 16.9.1, --no-auto-version, --no-version-vectors, --no-version-transitions, --no-resource-deduping, --allow-reserved-package-id, -e, /tmp/APKTOOL17017271800784647292.tmp, -0, arsc, -I, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/1.apk, --manifest, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/AndroidManifest.xml, /home/testu/Downloads/16.9.1/twitch_revanced-resource-cache/build/resources.zip]
	at brut.util.OS.exec(OS.java:104)
	at brut.androlib.AaptInvoker.invokeAapt2(AaptInvoker.java:242)
	... 13 more

Solution

fix the error so that creating patched twitch apk is possible again

Additional context

• The error occurred on the following supported versions of Twitch

  • 16.9.1
  • 16.1.0
  • 15.4.1
    • affects all versions, so to speak

• I'm not a Java/Kotlin developer and therefore can't help fix the code

Acknowledgements

• This issue is not a duplicate of an existing bug report.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[LisoUseInAIKyrios]

During a recent refactoring some Twitch strings were overlooked and need to be added again.

For now, patch using the prior patches/integrations release and it will work.

edit: All strings are present. Something else is going wrong.

[cyberboh]

During a recent refactoring some Twitch strings were overlooked and need to be added again.

For now, patch using the prior patches/integrations release and it will work.

It won't, see my issue ReVanced/revanced-cli#310
It's basically the same issue

[LisoUseInAIKyrios]

It won't, see my issue ReVanced/revanced-cli#310 It's basically the same issue

I'm not seeing that issue. I can patch YouTube and YT Music using latest CLI/Integrations/Patches release and it works for me.

However I also cannot patch Twitch using CLI tools (gives the same error)