Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Spoof app version): 17.33.42 spoof target has the same layout as 17.41.37 #2808

Closed
3 tasks done
HattieJosh opened this issue Mar 2, 2024 · 12 comments
Closed
3 tasks done
Labels
Bug report Something isn't working

Comments

@HattieJosh
Copy link

HattieJosh commented Mar 2, 2024

Bug description

Installing the patch to fix the watch history has caused the spoofing of app versions to show the new layout instead of what should be the spoofed layout. The spoof only appears to fix the thumbnails of videos on the home screen and nothing else
Screenshot_20240302_152247_YouTube
Screenshot_20240302_152236_YouTube
Screenshot_20240302_151742_YouTube

Error logs

No response

Solution

No response

Additional context

No response

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@HattieJosh HattieJosh added the Bug report Something isn't working label Mar 2, 2024
@oSumAtrIX oSumAtrIX changed the title bug: New watch history patch breaks app version spoofing bug(YouTube(: v17.33.42 spoofing not working Mar 2, 2024
@oSumAtrIX oSumAtrIX changed the title bug(YouTube(: v17.33.42 spoofing not working bug(YouTube): v17.33.42 spoofing not working Mar 2, 2024
@oSumAtrIX oSumAtrIX added the Prioritized Prioritization over other issues label Mar 2, 2024
@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Mar 2, 2024

This is not an issue with the watch history fix.

Just so it's clear, the 16.x and 17.08.35 spoof targets were removed because YT is shutting down support for those versions and soon they will not work for anyone.

That means the really old player layout is gone.

Now the oldest available is 17.33.42, which is almost identical to 17.41.37 except the action buttons are above the channel bar:
Saxophone superstar Sergio Flores is above the action buttons

But if the spoof targets are changed multiple times (or sometimes just by random luck), the 17.41.37 layout is used even when target 17.33.42 selected.

The only nearly guaranteed way to get the 17.33.42 layout is:

  1. Clear YT ReVanced app data (or uninstall then reinstall, but do not launch the app yet)
  2. Turn on airplane mode with wifi turned off
  3. Launch YT ReVanced
  4. Turn on version spoofing with target 17.33.42
  5. Exit YT
  6. Turn on wifi/cellular
  7. Launch YT ReVanced
  8. Restart YT ReVanced

Now you'll have the oldest layout available.

It is expected that eventually 17.33.42 will no longer give any differences and 17.41.37 will then be the oldest available.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug(YouTube): v17.33.42 spoofing not working bug(YouTube - Spoof app version): 17.33.42 spoof target has the same layout as 17.41.37 Mar 2, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios removed the Prioritized Prioritization over other issues label Mar 2, 2024
@LisoUseInAIKyrios
Copy link
Contributor

Since it's so stubborn to apply the older layout (And the steps above are not explained anywhere else), the spoof version patch could automatically clear the app data when the spoof target is changed.

That would fix a lot of issues automatically, including the UI getting stuck on the old library tab layout when spoofing is turned off.

The only downside is the YT settings would be reset to default, but the ReVanced settings would be automatically kept.

@Sam101011
Copy link
Sponsor

Like @LisoUseInAIKyrios already mentioned, the old non-rounded UI is gone for good. I liked it a lot and used it 'till its last day, but it's gone.

The difference between the bottom player layouts of 17.33.42 and 17.41.37 are not as big as between the previous and the rounded UI(you can see the difference as shown here:#2776 (comment))

In order to get the 17.33.42 bottom player layout, first you need to spoof to said version and after the restart, force stop ReVanced and clear app cache(that worked for me at least).

Since it's so stubborn to apply the older layout (And the steps above are not explained anywhere else), the spoof version patch could automatically clear the app data when the spoof target is changed.

Imo, only clearing the cache should do the trick, instead of all data(this has done the trick for me like 90% of the time). Or, clearing cache and clearing data could be added as separate options when spoofing app version.

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Mar 2, 2024

Clearing the cache worked for me as well.

Edit: after being so stubborn to apply 17.33.42, after clearing the cache now it's permanently stuck on 17.33.42 no matter what spoof target is selected (even if the cache is cleared each time).

I think automatic clearing the app data might be the most headache free approach, and it's the only surefire way to apply a specific target.

The spoof version function is built into YT and baked into the app manifest. So it's expected usage is likely to be for fresh installations and not in environments polluted with app data from different app versions.

@Sam101011
Copy link
Sponsor

@LisoUseInAIKyrios for me the opposite thing happened. I spoofed to 17.41.37 and the layout changed, but it got stuck on this layout even when I changed back to 17.33.42(even with force stopping and clearing cache multiple times).

So yes, if you find a way to clear data when applying this patch and auto keep revanced settings, it'd be a good solution.

@pep0w

This comment was marked as abuse.

@LisoUseInAIKyrios
Copy link
Contributor

@pep0w while spoofing to 17.08.35, log out of your YT account and try to log back in. You won't be able to.

Right now the old versions are being turned off for specific users, and soon it won't work for any accounts. Logging in with those versions is turned off for everyone right now.

It makes no sense including those targets if it requires a paragraph of disclaimers and limitations, when soon the targets will be turned off for everyone.

@pep0w

This comment was marked as abuse.

@LisoUseInAIKyrios
Copy link
Contributor

Why not add a setting to enter version target manually just like Revanced Extended has?

Because there is a limited set of spoof targets that are useful (and they are already included as options). A free form version text box will have no use after 17.08.x is turned off for everyone.

Keep using a fork for the short time you have left, because you probably have only a few weeks left before being cut off.

@pep0w

This comment was marked as abuse.

@oSumAtrIX
Copy link
Member

The layout structures are sent by the server. Once the servers shut down, the next releases of the clients will remove the deprecated code which essentially would require writing the app from scratch to revert these changes. Unviable.

@oSumAtrIX
Copy link
Member

Seems the initial issue is invalid.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants