-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Boost for reddit - Fix missing audio in video downloads): Replace correct strings #3379
Conversation
…alid string replacement
ae0fe85
to
3cc16f3
Compare
...patches/reddit/customclients/boostforreddit/fix/downloads/FixAudioMissingInDownloadsPatch.kt
Show resolved
Hide resolved
## [4.10.1-dev.2](v4.10.1-dev.1...v4.10.1-dev.2) (2024-06-24) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([#3379](#3379)) ([b43db98](b43db98))
I tested it using the 4.11.0-dev2 patches which afaik should have the fix and it still doesn't work for me |
Tested patch with |
I'm not great with cli, so I used rvx (after telling it to use revanced patches) and told it to use the pre-release patches. I'll probably just wait until the patches get pushed to main and retry then. |
# [4.11.0](v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([#3379](#3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([#3402](#3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([#3397](#3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([#3365](#3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([#3415](#3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([#3331](#3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([#3334](#3334)) ([9414122](9414122)) * Add translations ([#2963](#2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([#3366](#3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([#3380](#3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([#3321](#3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([#3386](#3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([#3359](#3359)) ([fbd0507](fbd0507))
# [4.11.0](v4.10.0...v4.11.0) (2024-07-11) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([ReVanced#3379](https://github.com/E85Addict/revanced-patches/issues/3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([ReVanced#3402](https://github.com/E85Addict/revanced-patches/issues/3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([ReVanced#3397](https://github.com/E85Addict/revanced-patches/issues/3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([ReVanced#3365](https://github.com/E85Addict/revanced-patches/issues/3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([ReVanced#3415](https://github.com/E85Addict/revanced-patches/issues/3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([ReVanced#3331](https://github.com/E85Addict/revanced-patches/issues/3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([ReVanced#3334](https://github.com/E85Addict/revanced-patches/issues/3334)) ([9414122](9414122)) * Add translations ([ReVanced#2963](https://github.com/E85Addict/revanced-patches/issues/2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([ReVanced#3366](https://github.com/E85Addict/revanced-patches/issues/3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([ReVanced#3380](https://github.com/E85Addict/revanced-patches/issues/3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([ReVanced#3321](https://github.com/E85Addict/revanced-patches/issues/3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([ReVanced#3386](https://github.com/E85Addict/revanced-patches/issues/3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](https://github.com/E85Addict/revanced-patches/issues/3359)) ([fbd0507](fbd0507)) ### Performance Improvements * Personal Logo && Add upstream sync ([0d56aa1](0d56aa1))
# [4.11.0](v4.10.0...v4.11.0) (2024-07-12) ### Bug Fixes * **Boost for reddit - Fix missing audio in video downloads:** Replace correct strings ([ReVanced#3379](https://github.com/E85Addict/revanced-patches/issues/3379)) ([b43db98](b43db98)) * **Windy - Unlock pro:** Revert changing package name ([ReVanced#3402](https://github.com/E85Addict/revanced-patches/issues/3402)) ([541f1e7](541f1e7)) * **Windy - Unlock pro:** Use correct package name ([ReVanced#3397](https://github.com/E85Addict/revanced-patches/issues/3397)) ([1d8459a](1d8459a)) * **YouTube - Hide layout components:** Detect if a keyword filter hides all videos ([ReVanced#3365](https://github.com/E85Addict/revanced-patches/issues/3365)) ([6aa47ec](6aa47ec)) * **YouTube - Settings:** Move some settings to different menus, adjust default setting values ([ReVanced#3415](https://github.com/E85Addict/revanced-patches/issues/3415)) ([7201ac4](7201ac4)) * **YouTube - SponsorBlock:** Skip segments when casting ([ReVanced#3331](https://github.com/E85Addict/revanced-patches/issues/3331)) ([d9395fd](d9395fd)) ### Features * Add `Remove share targets` patch ([ReVanced#3334](https://github.com/E85Addict/revanced-patches/issues/3334)) ([9414122](9414122)) * Add translations ([ReVanced#2963](https://github.com/E85Addict/revanced-patches/issues/2963)) ([69ea6f3](69ea6f3)) * **Bandcamp:** Add `Remove play limits` patch ([ReVanced#3366](https://github.com/E85Addict/revanced-patches/issues/3366)) ([ad8d3bb](ad8d3bb)) * **Instagram:** Add `Hide ads` patch ([ReVanced#3380](https://github.com/E85Addict/revanced-patches/issues/3380)) ([c6b2f8c](c6b2f8c)) * **RAR:** Add `Hide purchase reminder` patch ([ReVanced#3321](https://github.com/E85Addict/revanced-patches/issues/3321)) ([8fbe7e3](8fbe7e3)) * **Soundcloud:** Add `Hide ads` and `Disable telemetry` patch ([ReVanced#3386](https://github.com/E85Addict/revanced-patches/issues/3386)) ([3c79f3d](3c79f3d)) * **Stocard:** Add `Hide offers tab` and `Hide story bubbles` patch ([ReVanced#3359](https://github.com/E85Addict/revanced-patches/issues/3359)) ([fbd0507](fbd0507)) ### Performance Improvements * Personal Logo && Add upstream sync ([6ded142](6ded142))
Some refactor broke the audio download feature, resulting in
v.redd.it
and/
strings getting replaced instead of audio endpoints resulting in client not even trying to download audio. This fixes that, by removing these two strings and keeping only/DASH_audio.mp4
and/audio
. Both strings are unique in final version of Boost.