Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SoundCloud): Add Enable offline sync patch #3407

Merged
merged 11 commits into from
Jul 13, 2024

Conversation

BenCat07
Copy link
Contributor

@BenCat07 BenCat07 commented Jul 2, 2024

Depends on #3386

Enables the offline download Feature, allowing listening to tracks without internet

It patches the request Involved to use the https stream endpoint instead. (from /tracks/(id)/offline_sync -> /tracks/(id)/streams/https)

There 3 (purely cosmetic) headers missing on this endpoint that crash SoundCloud, they get replaced with empty Strings if detected as null.

@BenCat07 BenCat07 changed the title Allow Soundcloud Offline track Downloading feat(Soundcloud): Allow Soundcloud Offline track Downloading Jul 2, 2024
@BenCat07 BenCat07 changed the title feat(Soundcloud): Allow Soundcloud Offline track Downloading feat(Soundcloud): Allow offline track downloading Jul 2, 2024
@oSumAtrIX oSumAtrIX changed the title feat(Soundcloud): Allow offline track downloading feat(SoundCloud): Allow offline track downloading Jul 2, 2024
@BenCat07 BenCat07 marked this pull request as ready for review July 11, 2024 18:30
@oSumAtrIX oSumAtrIX changed the title feat(SoundCloud): Allow offline track downloading feat(SoundCloud): Add Enable offline sync patch Jul 13, 2024
@oSumAtrIX oSumAtrIX merged commit 4de86c6 into ReVanced:dev Jul 13, 2024
2 checks passed
Copy link

welcome bot commented Jul 13, 2024

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

revanced-bot pushed a commit that referenced this pull request Jul 13, 2024
# [4.12.0-dev.1](v4.11.1-dev.1...v4.12.0-dev.1) (2024-07-13)

### Features

* **SoundCloud:** Add `Enable offline sync` patch ([#3407](#3407)) ([4de86c6](4de86c6))
revanced-bot pushed a commit that referenced this pull request Aug 6, 2024
# [4.12.0](v4.11.0...v4.12.0) (2024-08-06)

### Bug Fixes

* **Google Photos - GmsCore support:** Fix by checking first if a method exists before trying to patch it ([acf38ca](acf38ca))
* **Instagram - Hide ads:**  Restore compatibility with latest version by fixing fingerprint ([#3455](#3455)) ([4505fa4](4505fa4))
* **Messenger - Disable switching emoji to sticker:** Constrain to last working version `439.0.0.29.119` ([6207c31](6207c31))
* **SoundCloud - Enable offline sync:** Stop crashing by reversing order of patching instructions from last to first to retain indices ([63b6ced](63b6ced))
* **YouTube - Bypass image region restrictions:** Move setting to `Misc` menu ([094ae59](094ae59))
* **YouTube - Client Spoof:** Restore missing high qualities by spoofing the iOS client user agent ([#3468](#3468)) ([0e6ae5f](0e6ae5f))
* **YouTube - Hide keyword content:** Do not hide flyout menu ([687c9f7](687c9f7))
* **YouTube - SponsorBlock:** Correctly show minute timestamp when creating a new segment ([d74c366](d74c366))
* **YouTube - SponsorBlock:** Improve create segment manual seek accuracy ([#3491](#3491)) ([1544981](1544981))
* **YouTube - Spoof client:** Fix tracking history on brand accounts ([#3480](#3480)) ([69c1f16](69c1f16))
* **YouTube - Spoof client:** Restore livestream audio only playback with iOS spoofing ([#3504](#3504)) ([90d3288](90d3288))

### Features

* Add `Hide mock location` patch ([#3417](#3417)) ([5f81b40](5f81b40))
* Add `Spoof build info` patch ([e7829b4](e7829b4))
* **Boost for Reddit:** Add `Disable ads` patch ([#3474](#3474)) ([b292c20](b292c20))
* **CandyLink:** Remove non-functional `Unlock pro` patch ([7ae9f8f](7ae9f8f))
* **Expense Manager:** Remove non-functional `Unlock pro` patch ([ebbcac7](ebbcac7))
* **Google News:** Add `Enable CustomTabs` and `GmsCore support` patch ([#3111](#3111)) ([ad59096](ad59096))
* **Google Photos:** Add `GmsCore support` patch ([#3414](#3414)) ([24528e0](24528e0))
* **Instagram:** Remove unnecessary `Hide timeline ads` patch ([5e1d001](5e1d001))
* **SoundCloud:** Add `Enable offline sync` patch ([#3407](#3407)) ([4de86c6](4de86c6))
* **SwissID:** Add `Remove Google Play Integrity Integrity check` patch ([#3478](#3478)) ([60492ae](60492ae))
* **YouTube - Description components:** Add `Hide 'Key concepts' section` option ([#3495](#3495)) ([d75b645](d75b645))
* **YouTube:** Add `Bypass image region restrictions` patch ([#3442](#3442)) ([765fab2](765fab2))
@moteb757

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants