feat(YouTube): Add Check watch history domain name resolution patch
#3537
Conversation
|
Will this work on DNS adblocker in router level and private DNS that using |
There was a problem hiding this comment.
A past patch was able to modify s.youtube.com to www.youtube.com. Perhaps it makes sense to fallback to www in case a blocker is detected. This would spare the user from yet another popup and can be triggered automatically without calling the user for action.
src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/misc/dnsresolver/DnsResolverVerificationPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/misc/dnsresolver/DnsResolverVerificationPatch.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/app/revanced/patches/youtube/misc/dnsresolver/DnsResolverVerificationPatch.kt
Outdated
Show resolved
Hide resolved
…DnsResolverVerificationPatch.kt Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
Co-authored-by: oSumAtrIX <johan.melkonyan1@web.de>
|
Automatically modifying This issue only shows up for users who installed a DNS blocker that uses that one problematic block list (other blockers such as AdGuard do not suffer this). So the user will still have issues with stock YT, using a browser, and everywhere else even if ReVanced tries to work around. Instead of presenting this as "Hey your bad DNS blocker is incorrectly blocking something important that is not an ad, but we will try to fix it (no guarantees this will work)", it's simpler to just say "Your bad DNS blocker is misbehaving, here's how you fix it with 100% certainty". |
oSumAtrIX
changed the title
Check watch history domain name resolution patch
# [4.13.0-dev.2](v4.13.0-dev.1...v4.13.0-dev.2) (2024-08-15) ### Features * **YouTube:** Add `Check watch history domain name resolution` patch ([#3537](#3537)) ([2af1425](2af1425))
# [4.13.0](v4.12.0...v4.13.0) (2024-08-15) ### Bug Fixes * **YouTube - GmsCore support:** Fix notifications not working by using the correct permissions ([19ddae2](19ddae2)) ### Features * **Google Photos:** Add `Spoof features` patch ([#3459](#3459)) ([7c218cd](7c218cd)) * **SCB Easy:** Remove broken `Remove debugging detection` patch ([#3518](#3518)) ([f4e23cb](f4e23cb)) * **YouTube:** Add `Check watch history domain name resolution` patch ([#3537](#3537)) ([2af1425](2af1425))
|
I wanted to say thank you so much for this patch! I had given up on watch history... |
Detects if
s.youtube.comis blocked by a third party ad blocker and displays a dialog informing the user.This is caused by a problematic ad blocker list that some third party DNS ad blockers use without consideration.
Integration changes