Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta version: Cannot read properties of undefined (reading 'current') #986

Closed
binomialstew opened this issue Mar 21, 2023 · 7 comments
Closed
Labels

Comments

@binomialstew
Copy link

binomialstew commented Mar 21, 2023

Describe the bug
I'm seeing Cannot read properties of undefined (reading 'current') in beta version 5.10.1-beta-9. I do not see this error in 5.10.1-beta.4.

Looks like ReactCurrentOwner.current is undefined.

@danielbarion
Copy link
Member

hi @binomialstew can you check our PRs and the comments (beta releases) and let me know if the latest beta releases work for you?

#984 yarn add react-tooltip@5.10.1-beta-10 - rollup

#982 yarn add react-tooltip@5.10.1-beta-9 - esbuild

@binomialstew
Copy link
Author

binomialstew commented Mar 22, 2023

Hi @danielbarion , I do not see the error in react-tooltip@5.10.1-beta-10. Unfortunately, that still contains the minification issue that I was looking at yesterday. beta-9 is the version where I saw the issue I raised here. So far, 5.10.1-beta.4 is functionally working but causes an eslint warning that we need to work around.

@gabrieljablonski
Copy link
Member

Same as said on #987.

Please test out react-tooltip@5.10.2-beta.4 and let us know about this specific issue.

@binomialstew
Copy link
Author

I don't see this issue any longer, but I do see this when trying to access the tooltip in a next.js@13.2.4 production build:

floating-ui.core.browser.min.mjs:1 Uncaught (in promise) TypeError: f is not a function
    at d (floating-ui.core.browser.min.mjs:1:860)

@gabrieljablonski
Copy link
Member

gabrieljablonski commented Apr 1, 2023

Can you try next@13.2.5-canary.22? Apparently this version fixed a similar issue for us, so I'd appreciate if you could test it.

@binomialstew
Copy link
Author

binomialstew commented Apr 3, 2023

This does appear to be fixed by using that version of next.js. For some reason, noArrow is not applying the class necessary to hide the arrow in your 5.10.2-beta.x. It's undefined on the div.react-tooltip-arrow element. This was working correctly in 5.10.1-beta.4.

I was unable to find branches that correspond to these beta releases. Are they here? I'd be able to provide more helpful info to you and make some things more clear to myself if I could take a look at the diffs.

@gabrieljablonski
Copy link
Member

gabrieljablonski commented Apr 3, 2023

For some reason, noArrow is not applying the class necessary to hide the arrow in your 5.10.2-beta.x

Just a slight oversight when refactoring some class names. Already fixed, thanks for reporting.

Regarding this issue we are considering it as a bug on Next.js, since the update fixes it.

react-tooltip@5.10.5 has been released, and it addresses the other issues that were closed today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants