Use Jest for testing

This commit uses Jest for testing everything instead of our homegrown combination of karma + mocha + expect. We were already using Jest to test react-router-redux and react-router-native, so this commit makes everything more consistent.
remix-run · Jul 14, 2017 · 172dc16 · ryanflorence · Jul 15, 2017 · stryju
1 parent 3964114
commit 172dc16
Show file tree

Hide file tree

Showing 28 changed files with 93 additions and 468 deletions.
diff --git a/packages/react-router-config/.gitignore b/packages/react-router-config/.gitignore
@@ -2,6 +2,4 @@ es
 node_modules
 umd
 /*.js
-!karma.conf.js
-!tests.webpack.js
 !webpack.config.js
diff --git a/packages/react-router-config/karma.conf.js b/packages/react-router-config/karma.conf.js
diff --git a/packages/react-router-config/modules/__tests__/matchRoutes-test.js b/packages/react-router-config/modules/__tests__/matchRoutes-test.js
@@ -1,5 +1,4 @@
 import matchRoutes from '../matchRoutes'
-import expect from 'expect'
 
 it('finds matched routes', () => {
   const routes = [

diff --git a/packages/react-router-config/modules/__tests__/renderRoutes-test.js b/packages/react-router-config/modules/__tests__/renderRoutes-test.js
@@ -26,7 +26,7 @@ describe('renderRoutes', () => {
       </StaticRouter>
     )
     expect(rendered.length).toEqual(1)
-    expect(rendered[0]).toMatch(routeToMatch)
+    expect(rendered[0]).toEqual(routeToMatch)
   })
 
   describe('Switch usage', () => {
@@ -45,7 +45,7 @@ describe('renderRoutes', () => {
         </StaticRouter>
       )
       expect(rendered.length).toEqual(1)
-      expect(rendered[0]).toMatch(routeToMatch)
+      expect(rendered[0]).toEqual(routeToMatch)
     })
 
     it('renders the first matched route in nested routes', () => {
@@ -70,8 +70,8 @@ describe('renderRoutes', () => {
         </StaticRouter>
       )
       expect(rendered.length).toEqual(2)
-      expect(rendered[0]).toMatch(routeToMatch)
-      expect(rendered[1]).toMatch(childRouteToMatch)
+      expect(rendered[0]).toEqual(routeToMatch)
+      expect(rendered[1]).toEqual(childRouteToMatch)
     })
   })
 

diff --git a/packages/react-router-config/package.json b/packages/react-router-config/package.json
@@ -22,7 +22,7 @@
     "prepublishOnly": "node ./tools/build.js",
     "clean": "git clean -fdX .",
     "lint": "eslint modules",
-    "test": "karma start --single-run"
+    "test": "jest"
   },
   "peerDependencies": {
     "react": "^15",
@@ -40,16 +40,8 @@
     "eslint": "^2.13.1",
     "eslint-plugin-import": "^1.15.0",
     "eslint-plugin-react": "^5.2.2",
-    "expect": "^1.20.1",
     "gzip-size": "^3.0.0",
-    "karma": "^0.13.22",
-    "karma-browserstack-launcher": "^1.0.1",
-    "karma-chrome-launcher": "^1.0.1",
-    "karma-mocha": "^1.0.1",
-    "karma-mocha-reporter": "^2.0.4",
-    "karma-sourcemap-loader": "^0.3.7",
-    "karma-webpack": "^1.7.0",
-    "mocha": "^2.5.3",
+    "jest": "^20.0.4",
     "pretty-bytes": "^3.0.1",
     "react": "^15.4.2",
     "react-addons-test-utils": "^15.4.2",

diff --git a/packages/react-router-config/tests.webpack.js b/packages/react-router-config/tests.webpack.js
diff --git a/packages/react-router-dom/.gitignore b/packages/react-router-dom/.gitignore
@@ -2,6 +2,4 @@ es
 node_modules
 umd
 /*.js
-!karma.conf.js
-!tests.webpack.js
 !webpack.config.js
diff --git a/packages/react-router-dom/karma.conf.js b/packages/react-router-dom/karma.conf.js
diff --git a/packages/react-router-dom/modules/__tests__/BrowserRouter-test.js b/packages/react-router-dom/modules/__tests__/BrowserRouter-test.js
@@ -1,4 +1,3 @@
-import expect from 'expect'
 import React from 'react'
 import ReactDOM from 'react-dom'
 import PropTypes from 'prop-types'
@@ -24,21 +23,22 @@ describe('A <BrowserRouter>', () => {
       </BrowserRouter>
     ), node)
 
-    expect(history).toBeAn('object')
+    expect(typeof history).toBe('object')
   })
 
   it('warns when passed a history prop', () => {
     const history = {}
     const node = document.createElement('div')
-    expect.spyOn(console, 'error')
+
+    spyOn(console, 'error')
 
     ReactDOM.render((
       <BrowserRouter history={history} />
     ), node)
 
-    expect(console.error.calls.length).toBe(1)
-    expect(console.error.calls[0].arguments[0]).toMatch(
-      /<BrowserRouter.*import \{ Router }/)
-    expect.restoreSpies()
+    expect(console.error.calls.count()).toBe(1)
+    expect(console.error.calls.argsFor(0)[0]).toContain(
+      '<BrowserRouter> ignores the history prop'
+    )
   })
 })
diff --git a/packages/react-router-dom/modules/__tests__/HashRouter-test.js b/packages/react-router-dom/modules/__tests__/HashRouter-test.js
@@ -1,4 +1,3 @@
-import expect from 'expect'
 import React from 'react'
 import ReactDOM from 'react-dom'
 import PropTypes from 'prop-types'
@@ -24,21 +23,22 @@ describe('A <HashRouter>', () => {
       </HashRouter>
     ), node)
 
-    expect(history).toBeAn('object')
+    expect(typeof history).toBe('object')
   })
 
   it('warns when passed a history prop', () => {
     const history = {}
     const node = document.createElement('div')
-    expect.spyOn(console, 'error')
+
+    spyOn(console, 'error')
 
     ReactDOM.render((
       <HashRouter history={history} />
     ), node)
 
-    expect(console.error.calls.length).toBe(1)
-    expect(console.error.calls[0].arguments[0]).toMatch(
-      /<HashRouter.*import \{ Router }/)
-    expect.restoreSpies()
+    expect(console.error.calls.count()).toBe(1)
+    expect(console.error.calls.argsFor(0)[0]).toContain(
+      '<HashRouter> ignores the history prop'
+    )
   })
 })
diff --git a/packages/react-router-dom/modules/__tests__/Link-test.js b/packages/react-router-dom/modules/__tests__/Link-test.js
@@ -1,4 +1,3 @@
-import expect from 'expect'
 import React from 'react'
 import ReactDOM from 'react-dom'
 import MemoryRouter from 'react-router/MemoryRouter'