Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UMD module with developer warnings #3213

Merged
merged 1 commit into from
Mar 21, 2016

Conversation

gcorne
Copy link
Contributor

@gcorne gcorne commented Mar 21, 2016

For folks that need to use the UMD build, it would be nice if there was a build that included the warnings that folks could use during development.

@taion
Copy link
Contributor

taion commented Mar 21, 2016

For consistency with React, we should just use NODE_ENV=development for the normal un-minified UMD build. Care to amend this to just change that build script?

@gcorne gcorne force-pushed the add/umd-dev-build branch from 4517a2c to ad5ee12 Compare March 21, 2016 15:52
@gcorne
Copy link
Contributor Author

gcorne commented Mar 21, 2016

@taion made the tweak.

@taion
Copy link
Contributor

taion commented Mar 21, 2016

Thanks.

taion added a commit that referenced this pull request Mar 21, 2016
Add UMD module with developer warnings
@taion taion merged commit 409513b into remix-run:master Mar 21, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants