-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose generatePath #5661
Expose generatePath #5661
Conversation
I know that the As far as the question of whether or not it should actually be public API goes, I am not sure. I suppose since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After a closer review, the changes necessary for this are actually slightly more involved than just adding this line.
- The file needs to be added to the list of files in
package.json
. - Additionally, the
react-router-dom
package would need to be updated to re-export this.
As a reminder, this was added by #5209 to allow |
@pshrmn done. |
Can this be merged? |
Thanks! |
Is there a way to use master branch of the react router in my project? |
when will this be included in the released versions? |
When it's released. |
FYI I just created a PR to update
|
179: Update dependency react-router-dom to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router-dom](https://github.com/ReactTraining/react-router) from `v4.2.2` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...a27bc56) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `https://github.com/ReactTraining/react-router/pull/6172` [#​6118]: `https://github.com/ReactTraining/react-router/pull/6118` [#​5209]: `https://github.com/ReactTraining/react-router/pull/5209` [#​5489]: `https://github.com/ReactTraining/react-router/pull/5489` [#​5596]: `https://github.com/ReactTraining/react-router/pull/5596` [#​5661]: `https://github.com/ReactTraining/react-router/pull/5661` [#​5589]: `https://github.com/ReactTraining/react-router/pull/5589` [#​5720]: `https://github.com/ReactTraining/react-router/pull/5720` [#​5508]: `https://github.com/ReactTraining/react-router/pull/5508` [#​5792]: `https://github.com/ReactTraining/react-router/pull/5792` [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `https://github.com/ReactTraining/react-router/pull/5964` [#​5722]: `https://github.com/ReactTraining/react-router/pull/5722` --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.2...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `https://github.com/ReactTraining/react-router/pull/5209` [#​5489]: `https://github.com/ReactTraining/react-router/pull/5489` [#​5596]: `https://github.com/ReactTraining/react-router/pull/5596` [#​5661]: `https://github.com/ReactTraining/react-router/pull/5661` [#​5589]: `https://github.com/ReactTraining/react-router/pull/5589` [#​5720]: `https://github.com/ReactTraining/react-router/pull/5720` [#​5508]: `https://github.com/ReactTraining/react-router/pull/5508` [#​5792]: `https://github.com/ReactTraining/react-router/pull/5792` [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `https://github.com/ReactTraining/react-router/pull/5964` [#​5722]: `https://github.com/ReactTraining/react-router/pull/5722` --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
178: Update dependency react-router to v4.3.0 r=magopian a=renovate[bot] This Pull Request updates dependency [react-router](https://github.com/ReactTraining/react-router) from `v4.2.0` to `v4.3.0` <details> <summary>Release Notes</summary> ### [`v4.3.0`](https://github.com/ReactTraining/react-router/blob/master/CHANGELOG.md#v430httpsgithubcomReactTrainingreact-routercomparev420v430) [Compare Source](remix-run/react-router@v4.3.0-rc.3...v4.3.0) > Jun 6, 2018 * Use the `pretty` option in generatePath ([#​6172] by @​sibelius) * aria-current has incorrect value "true" ([#​6118] by @​brandonrninefive) * Redirect with parameters ([#​5209] by @​dlindenkreuz) * Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) * Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) * Expose `generatePath` ([#​5661] by @​rybon) * Use named import of history module. ([#​5589] by @​RoboBurned) * Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) * Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) * Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) * Use Prettier on the code ([e6f9017] by @​mjackson) * Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) * Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​6172]: `https://github.com/ReactTraining/react-router/pull/6172` [#​6118]: `https://github.com/ReactTraining/react-router/pull/6118` [#​5209]: `https://github.com/ReactTraining/react-router/pull/5209` [#​5489]: `https://github.com/ReactTraining/react-router/pull/5489` [#​5596]: `https://github.com/ReactTraining/react-router/pull/5596` [#​5661]: `https://github.com/ReactTraining/react-router/pull/5661` [#​5589]: `https://github.com/ReactTraining/react-router/pull/5589` [#​5720]: `https://github.com/ReactTraining/react-router/pull/5720` [#​5508]: `https://github.com/ReactTraining/react-router/pull/5508` [#​5792]: `https://github.com/ReactTraining/react-router/pull/5792` [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `https://github.com/ReactTraining/react-router/pull/5964` [#​5722]: `https://github.com/ReactTraining/react-router/pull/5722` --- ### [`v4.3.0-rc.3`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.3) [Compare Source](remix-run/react-router@v4.3.0-rc.2...v4.3.0-rc.3) - Fix broken UMD builds. - Add sideEffects: false for webpack tree shaking (#​6082 by @​taylorc93) --- ### [`v4.3.0-rc.2`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.2) [Compare Source](remix-run/react-router@v4.3.0-rc.1...v4.3.0-rc.2) - Bump `hoist-non-react-statics` for React 16.3. - Missing `generatePath` in `react-router-dom` package. --- ### [`v4.3.0-rc.1`](https://github.com/ReactTraining/react-router/releases/v4.3.0-rc.1) [Compare Source](remix-run/react-router@v4.2.0...v4.3.0-rc.1) > Mar 26, 2018 - Redirect with parameters ([#​5209] by @​dlindenkreuz) - Fix with missing pathname: `<Link to="?foo=bar">` ([#​5489] by @​pshrmn) - Escape NavLink path to allow special characters in path. ([#​5596] by @​esiegel) - Expose `generatePath` ([#​5661] by @​rybon) - Use named import of history module. ([#​5589] by @​RoboBurned) - Hoist dependencies for smaller UMD builds ([#​5720] by @​pshrmn) - Remove aria-current from navLink when inactive ([#​5508] by @​AlmeroSteyn) - Add invariant for missing "to" property on `<Link>` ([#​5792] by @​selbekk) - Use Prettier on the code ([e6f9017] by @​mjackson) - Fix pathless route's match when parent is null ([#​5964] by @​pshrmn) - Use history.createLocation in `<StaticRouter>` ([#​5722] by @​pshrmn) [#​5209]: `https://github.com/ReactTraining/react-router/pull/5209` [#​5489]: `https://github.com/ReactTraining/react-router/pull/5489` [#​5596]: `https://github.com/ReactTraining/react-router/pull/5596` [#​5661]: `https://github.com/ReactTraining/react-router/pull/5661` [#​5589]: `https://github.com/ReactTraining/react-router/pull/5589` [#​5720]: `https://github.com/ReactTraining/react-router/pull/5720` [#​5508]: `https://github.com/ReactTraining/react-router/pull/5508` [#​5792]: `https://github.com/ReactTraining/react-router/pull/5792` [e6f9017]: remix-run/react-router@e6f9017 [#​5964]: `https://github.com/ReactTraining/react-router/pull/5964` [#​5722]: `https://github.com/ReactTraining/react-router/pull/5722` --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
I need this so I can build up parameterized URLs outside of a React component, such as in a saga.