-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMG/Cantera compatibility for Plog reactions #2428
Comments
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
this is still relevant. |
This issue is being automatically marked as stale because it has not received any interaction in the last 90 days. Please leave a comment if this is still a relevant issue, otherwise it will automatically be closed in 30 days. |
Bug Description
This isn't necessarily an RMG/cantera bug, it is just a difference of how reactions are interpreted in each.
For plog reactions, RMG represents multiple plog reactions in chemkin by marking them as "duplicates":
the above mechanism can be converted to a cantera yaml file, but attempting to use it in a cantera reactor will give the following message:
the
PLOG/ 2000.000 0.000e+00 0.000 0.000 /
line is what causes the error. Cantera evaluates the reactions separately at a number of temperatures and pressures as part of it's validation procedure. In order for this representation to be interpreted at all, the above line needs to be commented out.This reaction can alternatively be represented as follows, which will yield no errors:
The two representations (2 reactions with the 2000 atm rate commented out vs 1 reaction) yield different results for rates in cantera at 2000 atm (see minimal example for code used to generate this:)
How To Reproduce
I have attached a minimal example with a jupyter notebook and chemkin/cantera input files.
Expected Behavior
I think it requires some thought, but I believe the "combined" method is how we want to represent reactions before we port them to Cantera.
Installation Information
Describe your installation method and system information.
Additional Context
this came up in #2288, you can refer to that for additional context.
see below for minimal example:
chemkin_error.zip
The text was updated successfully, but these errors were encountered: