-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
None of our regression tests use RMS reactors #2442
Labels
Comments
So we have an example from @mjohnson541 that uses the RMS Constant V Ideal Gas Reactor here already on hand - all we need is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The testing framework runs the examples in
RMG-Py/test/regression
which use the following reactor types:
so the RMS reactor types are not being tested in this CI framework.
I think at least one of the regression tests should use an RMS reactor, so that a "full run" of RMG that uses RMS is tested via CI.
The text was updated successfully, but these errors were encountered: