Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

None of our regression tests use RMS reactors #2442

Closed
rwest opened this issue May 17, 2023 · 1 comment · Fixed by #2446
Closed

None of our regression tests use RMS reactors #2442

rwest opened this issue May 17, 2023 · 1 comment · Fixed by #2446
Assignees

Comments

@rwest
Copy link
Member

rwest commented May 17, 2023

The testing framework runs the examples in RMG-Py/test/regression
which use the following reactor types:

aromatics/input.py:simpleReactor(
liquid_oxidation/input.py:liquidReactor(
nitrogen/input.py:simpleReactor(
oxidation/input.py:simpleReactor(
sulfur/input.py:simpleReactor(
sulfur/input.py:simpleReactor(
superminimal/input.py:simpleReactor(

so the RMS reactor types are not being tested in this CI framework.

I think at least one of the regression tests should use an RMS reactor, so that a "full run" of RMG that uses RMS is tested via CI.

@JacksonBurns
Copy link
Contributor

So we have an example from @mjohnson541 that uses the RMS Constant V Ideal Gas Reactor here already on hand - all we need is a regression_input.py (like we have for the other examples used in regression testing) and it could easily be added. I don't know how do this myself, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants