This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Fixes in rebuild-ts grunt task. #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebuild-ts task would wrongly exclude typings included in the rx.lite.d.ts file. For instance would rx.time.d.ts only receive the typings not included in rx.lite.d.ts. As it was, I could only use either rx.lite.d.ts or rx.all.d.ts. However, I use a subset with rx.d.ts, rx.binding.ts and rx.time.d.ts. This fix makes it possible to do that. Instead of excluding typings included in lite, the rebuild-ts task now correctly excludes typings included in main (rx.d.ts). The original behaviour is kept if lite typings are built. I believe this is the correct behaviour, and it works nicely in my setup. I can now use a subset of the typings. I've also fixed the declare module output of rx.d.ts. It would previously add the declare module "rx" line twice, resulting in a compiler error when included in a project.
ghost
added
the
mattpodwysocki
added a commit
that referenced
this pull request
Oct 12, 2015
Fixes in rebuild-ts grunt task.
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebuild-ts task would wrongly exclude typings included in the rx.lite.d.ts
file. For instance would rx.time.d.ts only receive the typings not
included in rx.lite.d.ts.
As it was, I could only use either rx.lite.d.ts or rx.all.d.ts. However,
I use a subset with rx.d.ts, rx.binding.ts and rx.time.d.ts. This fix
makes it possible to do that. Instead of excluding typings included in
lite, the rebuild-ts task now correctly excludes typings included in main
(rx.d.ts). The original behaviour is kept if lite typings are built. I
believe this is the correct behaviour, and it works nicely in my setup. I
can now use a subset of the typings and the original lite typings are the
same as before.
I've also fixed the declare module output of rx.d.ts. It would previously
add the declare module "rx" line twice, resulting in a compiler error when
included in a project.