-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add backend functionality to the core #174
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-4.0.0 #174 +/- ##
=============================================
- Coverage 91.74% 91.48% -0.26%
=============================================
Files 14 15 +1
Lines 1781 1774 -7
=============================================
- Hits 1634 1623 -11
- Misses 147 151 +4 ☔ View full report in Codecov by Sentry. |
wouterwln
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces "backends" to the GraphPPL framework, allowing external packages to connect with it and tweak specific node behaviors. Essentially, it lets us define aliases for nodes outside of GraphPPL, and also gives us the flexibility to adjust model creation based on certain flags in a backend.
Included in this PR tests are showcasing how this functionality works, like setting up aliases for custom "distributions".
The backend is also allowed to add/remove custom syntax transformation pipelines to the model parsing.
For user interaction, I've added
DefaultBackend
, which smoothly handles objects fromDistributions.jl
using the existing extension setup. New backends can build off this functionality, as demonstrated by the backend implemented intestutils.jl
.One thing to note is that the @model macro isn't exported anymore. Packages relying on it will need to import it explicitly or define their own with a different backend.
Additionally, this PR refines many old tests by incorporating the latest changes, such as using ModelGenerator consistently.