Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constraint implementation for multidimensional ResizableArrays #175

Merged
merged 39 commits into from
Mar 19, 2024
Merged

Constraint implementation for multidimensional ResizableArrays #175

merged 39 commits into from
Mar 19, 2024

Conversation

wouterwln
Copy link
Member

No description provided.

@wouterwln wouterwln requested a review from bvdmitri March 15, 2024 11:36
@codecov Codecov
Copy link

codecov bot commented Mar 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.62366% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 91.85%. Comparing base (580dbc6) to head (54eb171).
Report is 7 commits behind head on dev-4.0.0.

Files Patch % Lines
src/resizable_array.jl 92.30% 3 Missing ⚠️
src/graph_engine.jl 80.00% 1 Missing ⚠️
...onal_constraints/variational_constraints_engine.jl 97.95% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           dev-4.0.0     #175      +/-   ##
=============================================
+ Coverage      91.48%   91.85%   +0.36%     
=============================================
  Files             15       15              
  Lines           1774     1842      +68     
=============================================
+ Hits            1623     1692      +69     
+ Misses           151      150       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bvdmitri
bvdmitri reviewed Mar 18, 2024
View reviewed changes
src/resizable_array.jl Outdated Show resolved Hide resolved
@bvdmitri
Copy link
Member

ping me again when its ready

bvdmitri
bvdmitri approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @wouterwln

@wouterwln wouterwln merged commit b99d6a7 into dev-4.0.0 Mar 19, 2024
5 checks passed
@wouterwln wouterwln deleted the indices-for-multidim-resizablearray branch March 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvdmitri bvdmitri bvdmitri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterwln @bvdmitri