-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow MeanField
constraints
#189
Allow MeanField
constraints
#189
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is at least
q(mat) = MeanField()
allowed?
src/plugins/variational_constraints/variational_constraints_engine.jl
Outdated
Show resolved
Hide resolved
@bvdmitri of course it is, it goes through a different channel since |
…gine.jl Co-authored-by: Bagaev Dmitry <bvdmitri@gmail.com>
Good! Can we add a testcase where we apply |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-4.0.0 #189 +/- ##
=============================================
+ Coverage 91.92% 92.05% +0.13%
=============================================
Files 15 15
Lines 1845 1863 +18
=============================================
+ Hits 1696 1715 +19
+ Misses 149 148 -1 ☔ View full report in Codecov by Sentry. |
Added a test that tests matrices |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it!
This PR allows the following syntax:
While building this, I also found a bug. When
mat
is a matrix valued RV and the user specified:and obscure error was thrown. Because of the way we encode ranges in the current implementation we actually don't allow multidimensional splitted ranges so a helpful error message will now be thrown.