Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sampling from GammaShapeRate #339

Merged
merged 3 commits into from
Jul 12, 2023
Merged

fix sampling from GammaShapeRate #339

merged 3 commits into from
Jul 12, 2023

Conversation

bvdmitri
Copy link
Member

This PR fixes #337

@bvdmitri bvdmitri requested a review from albertpod July 11, 2023 15:14
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (5c9ca66) 67.44% compared to head (f1addaa) 67.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #339      +/-   ##
==========================================
- Coverage   67.44%   67.33%   -0.11%     
==========================================
  Files         210      210              
  Lines        7660     7660              
==========================================
- Hits         5166     5158       -8     
- Misses       2494     2502       +8     
Impacted Files Coverage Δ
src/distributions/gamma_shape_rate.jl 86.04% <100.00%> (+5.55%) ⬆️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bvdmitri bvdmitri merged commit 8f43259 into master Jul 12, 2023
6 of 7 checks passed
@bvdmitri bvdmitri deleted the fix-337 branch July 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rand for GammaShapeRate is broken.
2 participants