-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'v_a_vT' is slow and named wrong #343
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The function
v_a_vT
does not do what the name suggests, instead ofv * a * v'
it doesv * v' * a
. It works OK, because in the only context we use this functiona
is a number, so it commutes, but the name is misleading.Moreover, a naive implementation of
v * v' * a
outperforms our version by a factor of 4:The text was updated successfully, but these errors were encountered: