Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples need adjustments for new GraphPPL #242

Closed
22 of 23 tasks
bvdmitri opened this issue Apr 3, 2024 · 10 comments
Closed
22 of 23 tasks

Examples need adjustments for new GraphPPL #242

bvdmitri opened this issue Apr 3, 2024 · 10 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@bvdmitri
Copy link
Member

bvdmitri commented Apr 3, 2024

Migration guide

Basic examples

Advanced examples

Problem specific

@Nimrais
Copy link
Member

Nimrais commented Apr 3, 2024

@bvdmitri, I would like to fix Infinite Data Stream and Gamma Mixture.

@HoangMHNguyen
Copy link
Contributor

@bvdmitri I choose GPSDE and RTS vs BIFM

@Sepideh-Adamiat
Copy link
Contributor

@bvdmitri I choose the Mountain Car and Hidden Markov Model.

@wouterwln
Copy link
Member

On the Mountain Car example @Sepideh-Adamiat , it might be worthy of a revision in general. The current example is, I think, an example of @ThijsvdLaar 's 2019 paper on "Simulating Active Inference Processes by Message Passing", and you can see the ideas of the paper explicitly named and coded as such. However, as an example of RxInfer, the main goal is not to demonstrate the ideas of a paper, but to demonstrate how to make an agent operate in a simple environment. Therefore I think we might need to adopt "standard" coding practices in the Mountain Car demo too (instead of creating a function that returns a callback function that reads/writes to global variables), to make clear what code specifically belongs to RxInfer and what code is just there to whip up the environment. Let me know what you guys think

@Raphael-Tresor
Copy link
Contributor

@bvdmitri I would like to fix the 'Probit model' example and "Chance-constraints"

@mhidalgoaraya mhidalgoaraya self-assigned this Apr 3, 2024
@mhidalgoaraya
Copy link
Contributor

@bvdmitri I choose the Kalman Filtering and Smoothing example

@bartvanerp
Copy link
Member

Awesome work @wouterwln and @bvdmitri ! Migration was peanuts!

@bvdmitri bvdmitri added the documentation Improvements or additions to documentation label Apr 5, 2024
@bvdmitri bvdmitri added this to the RxInfer 3.0.0 release milestone Apr 5, 2024
@albertpod
Copy link
Member

@wouterwln as for Mountain Car. It's a great idea. We have more people interested in this particular example, but I agree that the way it's coded up isn't pretty. Mindful of that it needs to change, I am not sure what would be the best way. AFAIR, you had an implementation of this example with RxEnvironments. Could it be something to consider?

@Sepideh-Adamiat
Copy link
Contributor

@wouterwln Regarding the mountain car example: I also agree that the current version is confusing and the coding should be improved. I can start working on that. I will try to make a PR in the upcoming weeks.

@bvdmitri
Copy link
Member Author

Thanks everyone! It is super helpful! There is one example left, but I'm going to close the issue, as it becomes a bit difficult to manage different branches with different fixes together with the examples branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

9 participants