fix(fromnodestream): enable fromnodestream tests, fix minification problems #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
force-pushed
the
fromnodestream-spec
branch
from
a0a87db to
feb91bb
Compare
src/asynciterable/fromnodestream.ts
Outdated
| Ended, | ||
| Errored | ||
| } | ||
| const NonFlowing = 0; |
There was a problem hiding this comment.
probably a good idea to use SCREAMING_CASE for constants here
trxcllnt
force-pushed
the
fromnodestream-spec
branch
from
5e2a1b6 to
00eb341
Compare
trxcllnt
force-pushed
the
fromnodestream-spec
branch
from
00eb341 to
66014ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the
fromNodeStreamtests.Apparently TS enums don't minify well through closure-compiler, so I had to erase the enum and directly compare ints. Also Uglify erroneously minifies the EventEmitter method names, so I guard those by referencing via string indexers.