Skip to content

Commit 17341a4

Browse files
staltzkwonoj
authored andcommitted
fix(inspect): remove inspect and inspectTime operators
Remove inspect and inspectTime operators from this library, since they are unnecessary and don't exist in previous versions of RxJS. This change was suggested in issue #1053. BREAKING CHANGE: `inspect` and `inspectTime` were removed. Use `withLatestFrom` instead.
1 parent 0f38730 commit 17341a4

File tree

8 files changed

+0
-395
lines changed

8 files changed

+0
-395
lines changed

spec/operators/inspect-spec.js

Lines changed: 0 additions & 180 deletions
This file was deleted.

spec/operators/inspectTime-spec.js

Lines changed: 0 additions & 99 deletions
This file was deleted.

src/Observable.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,6 @@ export class Observable<T> implements CoreOperators<T> {
220220
elementSelector?: (value: T) => R,
221221
durationSelector?: (group: GroupedObservable<R>) => Observable<any>) => Observable<GroupedObservable<R>>;
222222
ignoreElements: () => Observable<T>;
223-
inspect: (notifier: Observable<any>) => Observable<T>;
224-
inspectTime: (delay: number, scheduler?: Scheduler) => Observable<T>;
225223
last: <R>(predicate?: (value: T, index: number) => boolean,
226224
resultSelector?: (value: T, index: number) => R,
227225
defaultValue?: any) => Observable<T> | Observable<R>;

src/Rx.KitchenSink.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@ export interface KitchenSinkOperators<T> extends CoreOperators<T> {
1111
distinctUntilKeyChanged?: (key: string, compare?: (x: any, y: any) => boolean) => Observable<T>;
1212
find?: (predicate: (value: T, index: number, source: Observable<T>) => boolean, thisArg?: any) => Observable<T>;
1313
findIndex?: (predicate: (value: T, index: number, source: Observable<T>) => boolean, thisArg?: any) => Observable<number>;
14-
inspect?: (notifier: Observable<any>) => Observable<T>;
15-
inspectTime?: (delay: number, scheduler?: IScheduler) => Observable<T>;
1614
max?: <T, R>(comparer?: (x: R, y: T) => R) => Observable<R>;
1715
min?: <T, R>(comparer?: (x: R, y: T) => R) => Observable<R>;
1816
timeInterval?: <T>(scheduler?: IScheduler) => Observable<T>;
@@ -76,8 +74,6 @@ import './add/operator/finally';
7674
import './add/operator/first';
7775
import './add/operator/groupBy';
7876
import './add/operator/ignoreElements';
79-
import './add/operator/inspect';
80-
import './add/operator/inspectTime';
8177
import './add/operator/isEmpty';
8278
import './add/operator/every';
8379
import './add/operator/last';

src/add/operator/inspect.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/add/operator/inspectTime.ts

Lines changed: 0 additions & 5 deletions
This file was deleted.

src/operator/inspect.ts

Lines changed: 0 additions & 55 deletions
This file was deleted.

0 commit comments

Comments
 (0)