fix(ajax): RxJS v6 TimeoutError is missing name property

ReactiveX · May 7, 2018 · 576d943 · 576d943
1 parent 7e4cef4
commit 576d943
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/spec/observables/dom/ajax-spec.ts b/spec/observables/dom/ajax-spec.ts
@@ -273,6 +273,7 @@ describe('Observable.ajax', () => {
     });
 
     expect(error instanceof Rx.AjaxError).to.be.true;
+    expect(error.name).to.equal('AjaxError');
     expect(error.message).to.equal('ajax error 404');
     expect(error.status).to.equal(404);
   });
@@ -843,7 +844,7 @@ describe('Observable.ajax', () => {
     delete root.XMLHttpRequest.prototype.onreadystatechange;
   });
 
-  it('should work fine when XMLHttpRequest ontimeout property is monkey patched', function() {
+  it('should work fine when XMLHttpRequest ontimeout property is monkey patched', function(done) {
     Object.defineProperty(root.XMLHttpRequest.prototype, 'ontimeout', {
       set(fn: (e: ProgressEvent) => any) {
         const wrapFn = (ev: ProgressEvent) => {
@@ -867,7 +868,8 @@ describe('Observable.ajax', () => {
     Rx.Observable.ajax(ajaxRequest)
       .subscribe({
         error(err) {
-          /* expected, ignore */
+          expect(err.name).to.equal('AjaxTimeoutError');
+          done();
         }
       });
 

diff --git a/src/internal/observable/dom/AjaxObservable.ts b/src/internal/observable/dom/AjaxObservable.ts
@@ -490,6 +490,7 @@ function parseXhrResponse(responseType: string, xhr: XMLHttpRequest) {
 export class AjaxTimeoutError extends AjaxError {
   constructor(xhr: XMLHttpRequest, request: AjaxRequest) {
     super('ajax timeout', xhr, request);
+    this.name = 'AjaxTimeoutError';
     (Object as any).setPrototypeOf(this, AjaxTimeoutError.prototype);
   }
 }