feat(reorganization): internal utils hidden

BREAKING CHANGE: Many internal use utilities like `isArray` are now hidden under `rxjs/internal`, they are implementation details and should not be used.

spec/helpers/test-helper.ts

@@ -2,7 +2,7 @@ declare const global: any;
 
 import * as Rx from '../../src/Rx';
 import { ObservableInput } from '../../src/Observable';
-import { root } from '../../src/util/root';
+import { root } from '../../src/internal/util/root';
 import { $$iterator } from '../../src/internal/symbol/iterator';
 import $$symbolObservable from 'symbol-observable';
 

spec/observables/dom/ajax-spec.ts

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 import * as sinon from 'sinon';
 import * as Rx from '../../../src/Rx';
-import { root } from '../../../src/util/root';
+import { root } from '../../../src/internal/util/root';
 
 declare const global: any;
 

spec/observables/fromEventPattern-spec.ts

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 import * as sinon from 'sinon';
 import * as Rx from '../../src/Rx';
-import { noop } from '../../src/util/noop';
+import { noop } from '../../src/internal/util/noop';
 import marbleTestingSignature = require('../helpers/marble-testing'); // tslint:disable-line:no-require-imports
 
 declare const { asDiagram };

spec/symbol/observable-spec.ts

@@ -1,7 +1,7 @@
 import { expect } from 'chai';
 import $$symbolObservable from 'symbol-observable';
 
-import { root } from '../../src/util/root';
+import { root } from '../../src/internal/util/root';
 import { getSymbolObservable } from '../../src/internal/symbol/observable';
 
 describe('observable symbol', () => {

spec/symbol/rxSubscriber-spec.ts

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { root } from '../../src/util/root';
+import { root } from '../../src/internal/util/root';
 import {$$rxSubscriber} from '../../src/internal/symbol/rxSubscriber';
 
 describe('rxSubscriber symbol', () => {

spec/util/Immediate-spec.ts

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { Immediate } from '../../src/util/Immediate';
+import { Immediate } from '../../src/internal/util/Immediate';
 
 describe('Immediate', () => {
  it('should schedule on the next microtask', (done) => {

spec/util/assign-spec.ts

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { assign, getAssign, assignImpl } from '../../src/util/assign';
+import { assign, getAssign, assignImpl } from '../../src/internal/util/assign';
 
 describe('assign', () => {
  it('should exist', () => {
@@ -46,4 +46,4 @@ describe('getAssign', () => {
  const result = getAssign({ Object: { assign: FAKE } });
  expect(result).to.equal(FAKE);
  });
-});
+});

spec/util/pipe-spec.ts

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { pipe } from '../../src/util/pipe';
+import { pipe } from '../../src/internal/util/pipe';
 
 describe('pipe', () => {
  it('should exist', () => {

spec/util/subscribeToResult-spec.ts

@@ -1,6 +1,6 @@
 import { expect } from 'chai';
 import * as Rx from '../../src/Rx';
-import { subscribeToResult } from '../../src/util/subscribeToResult';
+import { subscribeToResult } from '../../src/internal/util/subscribeToResult';
 import { OuterSubscriber } from '../../src/internal/OuterSubscriber';
 import { $$iterator } from '../../src/internal/symbol/iterator';
 import $$symbolObservable from 'symbol-observable';

spec/util/toSubscriber-spec.ts

@@ -1,5 +1,5 @@
 import { expect } from 'chai';
-import { toSubscriber } from '../../src/util/toSubscriber';
+import { toSubscriber } from '../../src/internal/util/toSubscriber';
 
 describe('toSubscriber', () => {
  it('should not be closed when other subscriber created with no arguments completes', () => {

src/Rx.ts

@@ -152,17 +152,17 @@ export {ReplaySubject} from './internal/ReplaySubject';
 export {BehaviorSubject} from './internal/BehaviorSubject';
 export {ConnectableObservable} from './internal/observable/ConnectableObservable';
 export {Notification} from './internal/Notification';
-export {EmptyError} from './util/EmptyError';
-export {ArgumentOutOfRangeError} from './util/ArgumentOutOfRangeError';
-export {ObjectUnsubscribedError} from './util/ObjectUnsubscribedError';
-export {TimeoutError} from './util/TimeoutError';
-export {UnsubscriptionError} from './util/UnsubscriptionError';
+export {EmptyError} from './internal/util/EmptyError';
+export {ArgumentOutOfRangeError} from './internal/util/ArgumentOutOfRangeError';
+export {ObjectUnsubscribedError} from './internal/util/ObjectUnsubscribedError';
+export {TimeoutError} from './internal/util/TimeoutError';
+export {UnsubscriptionError} from './internal/util/UnsubscriptionError';
 export {TimeInterval} from './internal/patching/operator/timeInterval';
 export {Timestamp} from './internal/operators/timestamp';
 export {TestScheduler} from './internal/testing/TestScheduler';
 export {VirtualTimeScheduler} from './internal/scheduler/VirtualTimeScheduler';
 export {AjaxRequest, AjaxResponse, AjaxError, AjaxTimeoutError} from './internal/observable/dom/AjaxObservable';
-export { pipe } from './util/pipe';
+export { pipe } from './internal/util/pipe';
 
 import { asap } from './internal/scheduler/asap';
 import { async } from './internal/scheduler/async';

src/index.ts

@@ -19,9 +19,9 @@ export { Subscription } from './internal/Subscription';
 export { Notification } from './internal/Notification';
 
 /* Utils */
-export { pipe } from './util/pipe';
-export { noop } from './util/noop';
-export { identity } from './util/identity';
+export { pipe } from './internal/util/pipe';
+export { noop } from './internal/util/noop';
+export { identity } from './internal/util/identity';
 
 /* Types */
 export * from './internal/types';

src/internal/BehaviorSubject.ts

@@ -1,7 +1,7 @@
 import { Subject } from './Subject';
 import { Subscriber } from './Subscriber';
 import { Subscription, ISubscription } from './Subscription';
-import { ObjectUnsubscribedError } from '../util/ObjectUnsubscribedError';
+import { ObjectUnsubscribedError } from './util/ObjectUnsubscribedError';
 
 /**
  * @class BehaviorSubject<T>

src/internal/Observable.ts

@@ -2,13 +2,13 @@ import { PartialObserver } from './Observer';
 import { Operator } from './Operator';
 import { Subscriber } from './Subscriber';
 import { Subscription, AnonymousSubscription, TeardownLogic } from './Subscription';
-import { root } from '../util/root';
-import { toSubscriber } from '../util/toSubscriber';
+import { root } from './util/root';
+import { toSubscriber } from './util/toSubscriber';
 import { IfObservable } from './observable/IfObservable';
 import { ErrorObservable } from './observable/ErrorObservable';
 import { observable as Symbol_observable } from '../internal/symbol/observable';
 import { OperatorFunction } from '../internal/types';
-import { pipeFromArray } from '../util/pipe';
+import { pipeFromArray } from './util/pipe';
 
 export interface Subscribable<T> {
  subscribe(observerOrNext?: PartialObserver<T> | ((value: T) => void),

src/internal/ReplaySubject.ts

@@ -4,7 +4,7 @@ import { queue } from './scheduler/queue';
 import { Subscriber } from './Subscriber';
 import { Subscription } from './Subscription';
 import { ObserveOnSubscriber } from './operators/observeOn';
-import { ObjectUnsubscribedError } from '../util/ObjectUnsubscribedError';
+import { ObjectUnsubscribedError } from './util/ObjectUnsubscribedError';
 import { SubjectSubscription } from './SubjectSubscription';
 /**
  * @class ReplaySubject<T>

src/internal/Subject.ts

@@ -3,7 +3,7 @@ import { Observer } from './Observer';
 import { Observable } from './Observable';
 import { Subscriber } from './Subscriber';
 import { ISubscription, Subscription, TeardownLogic } from './Subscription';
-import { ObjectUnsubscribedError } from '../util/ObjectUnsubscribedError';
+import { ObjectUnsubscribedError } from './util/ObjectUnsubscribedError';
 import { SubjectSubscription } from './SubjectSubscription';
 import { rxSubscriber as rxSubscriberSymbol } from '../internal/symbol/rxSubscriber';
 

src/internal/Subscriber.ts

@@ -1,4 +1,4 @@
-import { isFunction } from '../util/isFunction';
+import { isFunction } from './util/isFunction';
 import { Observer, PartialObserver, empty as emptyObserver } from './Observer';
 import { Subscription } from './Subscription';
 import { rxSubscriber as rxSubscriberSymbol } from '../internal/symbol/rxSubscriber';

src/internal/Subscription.ts

@@ -1,9 +1,9 @@
-import { isArray } from '../util/isArray';
-import { isObject } from '../util/isObject';
-import { isFunction } from '../util/isFunction';
-import { tryCatch } from '../util/tryCatch';
-import { errorObject } from '../util/errorObject';
-import { UnsubscriptionError } from '../util/UnsubscriptionError';
+import { isArray } from './util/isArray';
+import { isObject } from './util/isObject';
+import { isFunction } from './util/isFunction';
+import { tryCatch } from './util/tryCatch';
+import { errorObject } from './util/errorObject';
+import { UnsubscriptionError } from './util/UnsubscriptionError';
 
 export interface AnonymousSubscription {
  unsubscribe(): void;

src/internal/observable/ArrayObservable.ts

@@ -3,7 +3,7 @@ import { Observable } from '../Observable';
 import { ScalarObservable } from './ScalarObservable';
 import { EmptyObservable } from './EmptyObservable';
 import { Subscriber } from '../Subscriber';
-import { isScheduler } from '../../util/isScheduler';
+import { isScheduler } from '..//util/isScheduler';
 import { TeardownLogic } from '../Subscription';
 
 /**

src/internal/observable/BoundCallbackObservable.ts

@@ -2,8 +2,8 @@ import { Observable } from '../Observable';
 import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
 import { IScheduler } from '../Scheduler';
-import { tryCatch } from '../../util/tryCatch';
-import { errorObject } from '../../util/errorObject';
+import { tryCatch } from '..//util/tryCatch';
+import { errorObject } from '..//util/errorObject';
 import { AsyncSubject } from '../../internal/AsyncSubject';
 
 /**

src/internal/observable/BoundNodeCallbackObservable.ts

@@ -3,8 +3,8 @@ import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
 import { IScheduler } from '../Scheduler';
 import { Action } from '../scheduler/Action';
-import { tryCatch } from '../../util/tryCatch';
-import { errorObject } from '../../util/errorObject';
+import { tryCatch } from '..//util/tryCatch';
+import { errorObject } from '..//util/errorObject';
 import { AsyncSubject } from '../../internal/AsyncSubject';
 
 /**

src/internal/observable/DeferObservable.ts

@@ -2,7 +2,7 @@ import { Observable, SubscribableOrPromise } from '../Observable';
 import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
 
-import { subscribeToResult } from '../../util/subscribeToResult';
+import { subscribeToResult } from '..//util/subscribeToResult';
 import { OuterSubscriber } from '../OuterSubscriber';
 /**
  * We need this JSDoc comment for affecting ESDoc.

src/internal/observable/ForkJoinObservable.ts

@@ -2,9 +2,9 @@ import { Observable, SubscribableOrPromise } from '../Observable';
 import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
 import { EmptyObservable } from './EmptyObservable';
-import { isArray } from '../../util/isArray';
+import { isArray } from '..//util/isArray';
 
-import { subscribeToResult } from '../../util/subscribeToResult';
+import { subscribeToResult } from '..//util/subscribeToResult';
 import { OuterSubscriber } from '../OuterSubscriber';
 import { InnerSubscriber } from '../InnerSubscriber';
 

src/internal/observable/FromEventObservable.ts

@@ -1,7 +1,7 @@
 import { Observable } from '../Observable';
-import { tryCatch } from '../../util/tryCatch';
-import { isFunction } from '../../util/isFunction';
-import { errorObject } from '../../util/errorObject';
+import { tryCatch } from '..//util/tryCatch';
+import { isFunction } from '..//util/isFunction';
+import { errorObject } from '..//util/errorObject';
 import { Subscription } from '../Subscription';
 import { Subscriber } from '../Subscriber';
 

src/internal/observable/FromEventPatternObservable.ts

@@ -1,4 +1,4 @@
-import { isFunction } from '../../util/isFunction';
+import { isFunction } from '..//util/isFunction';
 import { Observable } from '../Observable';
 import { Subscription } from '../Subscription';
 import { Subscriber } from '../Subscriber';

src/internal/observable/FromObservable.ts

@@ -1,6 +1,6 @@
-import { isArray } from '../../util/isArray';
-import { isArrayLike } from '../../util/isArrayLike';
-import { isPromise } from '../../util/isPromise';
+import { isArray } from '..//util/isArray';
+import { isArrayLike } from '..//util/isArrayLike';
+import { isPromise } from '..//util/isPromise';
 import { PromiseObservable } from './PromiseObservable';
 import { IteratorObservable } from './IteratorObservable';
 import { ArrayObservable } from './ArrayObservable';

src/internal/observable/GenerateObservable.ts

@@ -3,7 +3,7 @@ import { Action } from '../scheduler/Action';
 import { Observable } from '../Observable' ;
 import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
-import { isScheduler } from '../../util/isScheduler';
+import { isScheduler } from '..//util/isScheduler';
 
 const selfSelector = <T>(value: T) => value;
 

src/internal/observable/IfObservable.ts

@@ -2,7 +2,7 @@ import { Observable, SubscribableOrPromise } from '../Observable';
 import { Subscriber } from '../Subscriber';
 import { TeardownLogic } from '../Subscription';
 
-import { subscribeToResult } from '../../util/subscribeToResult';
+import { subscribeToResult } from '..//util/subscribeToResult';
 import { OuterSubscriber } from '../OuterSubscriber';
 /**
  * We need this JSDoc comment for affecting ESDoc.

src/internal/observable/IntervalObservable.ts

@@ -1,5 +1,5 @@
 import { Subscriber } from '../Subscriber';
-import { isNumeric } from '../../util/isNumeric';
+import { isNumeric } from '..//util/isNumeric';
 import { IScheduler } from '../Scheduler';
 import { Observable } from '../Observable';
 import { async } from '../scheduler/async';

src/internal/observable/IteratorObservable.ts

@@ -1,4 +1,4 @@
-import { root } from '../../util/root';
+import { root } from '..//util/root';
 import { IScheduler } from '../Scheduler';
 import { Observable } from '../Observable';
 import { iterator as Symbol_iterator } from '../../internal/symbol/iterator';

src/internal/observable/NeverObservable.ts

@@ -1,6 +1,6 @@
 import { Observable } from '../Observable';
 import { Subscriber } from '../Subscriber';
-import { noop } from '../../util/noop';
+import { noop } from '..//util/noop';
 
 /**
  * We need this JSDoc comment for affecting ESDoc.

src/internal/observable/PromiseObservable.ts

@@ -1,4 +1,4 @@
-import { root } from '../../util/root';
+import { root } from '..//util/root';
 import { IScheduler } from '../Scheduler';
 import { Observable } from '../Observable';
 import { Subscriber } from '../Subscriber';

src/internal/observable/SubscribeOnObservable.ts

@@ -4,7 +4,7 @@ import { Subscriber } from '../Subscriber';
 import { Subscription } from '../Subscription';
 import { Observable } from '../Observable';
 import { asap } from '../scheduler/asap';
-import { isNumeric } from '../../util/isNumeric';
+import { isNumeric } from '..//util/isNumeric';
 
 export interface DispatchArg<T> {
  source: Observable<T>;

src/internal/observable/TimerObservable.ts

@@ -1,9 +1,9 @@
-import { isNumeric } from '../../util/isNumeric';
+import { isNumeric } from '..//util/isNumeric';
 import { IScheduler } from '../Scheduler';
 import { Observable } from '../Observable';
 import { async } from '../scheduler/async';
-import { isScheduler } from '../../util/isScheduler';
-import { isDate } from '../../util/isDate';
+import { isScheduler } from '..//util/isScheduler';
+import { isDate } from '..//util/isDate';
 import { TeardownLogic } from '../Subscription';
 import { Subscriber } from '../Subscriber';
 

src/internal/observable/UsingObservable.ts

@@ -2,7 +2,7 @@ import { Observable, SubscribableOrPromise } from '../Observable';
 import { Subscriber } from '../Subscriber';
 import { AnonymousSubscription, TeardownLogic } from '../Subscription';
 
-import { subscribeToResult } from '../../util/subscribeToResult';
+import { subscribeToResult } from '..//util/subscribeToResult';
 import { OuterSubscriber } from '../OuterSubscriber';
 /**
  * We need this JSDoc comment for affecting ESDoc.

src/internal/observable/combineLatest.ts

@@ -1,13 +1,13 @@
 import { Observable, ObservableInput } from '../Observable';
 import { IScheduler } from '../Scheduler';
-import { isScheduler } from '../../util/isScheduler';
-import { isArray } from '../../util/isArray';
+import { isScheduler } from '..//util/isScheduler';
+import { isArray } from '..//util/isArray';
 import { ArrayObservable } from './ArrayObservable';
 import { Subscriber } from '../Subscriber';
 import { OuterSubscriber } from '../OuterSubscriber';
 import { Operator } from '../Operator';
 import { InnerSubscriber } from '../InnerSubscriber';
-import { subscribeToResult } from '../../util/subscribeToResult';
+import { subscribeToResult } from '..//util/subscribeToResult';
 
 const NONE = {};
 

src/internal/observable/concat.ts

@@ -1,6 +1,6 @@
 import { Observable, ObservableInput } from '../Observable';
 import { IScheduler } from '../Scheduler';
-import { isScheduler } from '../../util/isScheduler';
+import { isScheduler } from '..//util/isScheduler';
 import { of } from './of';
 import { from } from './from';
 import { concatAll } from '../../internal/operators/concatAll';

src/internal/observable/dom/AjaxObservable.ts

@@ -1,6 +1,6 @@
-import { root } from '../../../util/root';
-import { tryCatch } from '../../../util/tryCatch';
-import { errorObject } from '../../../util/errorObject';
+import { root } from '../..//util/root';
+import { tryCatch } from '../..//util/tryCatch';
+import { errorObject } from '../..//util/errorObject';
 import { Observable } from '../../Observable';
 import { Subscriber } from '../../Subscriber';
 import { TeardownLogic } from '../../Subscription';

src/internal/observable/dom/WebSocketSubject.ts

@@ -3,12 +3,12 @@ import { Subscriber } from '../../Subscriber';
 import { Observable } from '../../Observable';
 import { Subscription } from '../../Subscription';
 import { Operator } from '../../Operator';
-import { root } from '../../../util/root';
+import { root } from '../..//util/root';
 import { ReplaySubject } from '../../ReplaySubject';
 import { Observer, NextObserver } from '../../Observer';
-import { tryCatch } from '../../../util/tryCatch';
-import { errorObject } from '../../../util/errorObject';
-import { assign } from '../../../util/assign';
+import { tryCatch } from '../..//util/tryCatch';
+import { errorObject } from '../..//util/errorObject';
+import { assign } from '../..//util/assign';
 
 export interface WebSocketSubjectConfig {
  url: string;