Skip to content

Commit

Permalink
fix(Scheduler): export but deprecate (#3522)
Browse files Browse the repository at this point in the history
There are a lot of people extending Scheduler, they really should not be, but we can give them time to fix things on their end before removing the reexport of Scheduler. Scheduler is an internal implementation detail.
  • Loading branch information
benlesh authored Apr 5, 2018
1 parent 8758a5d commit a3e1fb8
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export { async as asyncScheduler } from './internal/scheduler/async';
export { queue as queueScheduler } from './internal/scheduler/queue';
export { animationFrame as animationFrameScheduler } from './internal/scheduler/animationFrame';
export { VirtualTimeScheduler, VirtualAction } from './internal/scheduler/VirtualTimeScheduler';
export { Scheduler } from './internal/Scheduler';

/* Subscription */
export { Subscription } from './internal/Subscription';
Expand Down Expand Up @@ -70,4 +71,4 @@ export { NEVER } from './internal/observable/never';
export * from './internal/types';

/* Config */
export { config } from './internal/config';
export { config } from './internal/config';
3 changes: 3 additions & 0 deletions src/internal/Scheduler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ import { SchedulerLike, SchedulerAction } from './types';
* ```
*
* @class Scheduler
* @deprecated Scheduler is an internal implementation detail of RxJS, and
* should not be used directly. Rather, create your own class and implement
* {@link SchedulerLike}
*/
export class Scheduler implements SchedulerLike {

Expand Down

0 comments on commit a3e1fb8

Please sign in to comment.