Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable regression in ajax.getJSON after updating to 5.0.0-beta.11 #1874

Closed
zavan opened this issue Aug 10, 2016 · 4 comments · Fixed by #1875
Closed

Probable regression in ajax.getJSON after updating to 5.0.0-beta.11 #1874

zavan opened this issue Aug 10, 2016 · 4 comments · Fixed by #1875

Comments

@zavan
Copy link

zavan commented Aug 10, 2016

RxJS version:
5.0.0-beta.11

Code to reproduce:

import { Observable } from 'rxjs/Observable';
import { ajax } from 'rxjs/observable/dom/ajax';

console.log(ajax.getJSON('/api/v2/users'));

Expected behavior:
AjaxObservable { _isScalar: false, request: Object }

Actual behavior:
Uncaught (in promise) TypeError: (intermediate value).map is not a function(… ) in ajaxGetJSON

Additional information:
This is probably a regression caused by this commit: 7a77437
Introduced in 5.0.0-beta.11, since it works fine if I downgrade to 5.0.0-beta.10.

I'm using rxjs with redux-observable, if that makes any difference.

@kwonoj
Copy link
Member

kwonoj commented Aug 10, 2016

It seems it's due to 7a77437#diff-f80ecdc9803b338b8f47819f25b3a721R89, ajax now depends on map, while your reproducible import does not imports map operator patches to observable.

I'll try to update implementation, meanwhile import add/../map will resolve issue as immediate workaround.

@kwonoj
Copy link
Member

kwonoj commented Aug 11, 2016

@zavan , changes are checked in in master. You can verify behavior using master, or either wait next release published. Thanks for catching out issue!

@zavan
Copy link
Author

zavan commented Aug 11, 2016

@kwonoj Cool! Thank you for fixing it.

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants