Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sequenceEqual operator #1882

Closed
jskz opened this issue Aug 15, 2016 · 4 comments · Fixed by #1883
Closed

sequenceEqual operator #1882

jskz opened this issue Aug 15, 2016 · 4 comments · Fixed by #1883
Assignees
@benlesh
Labels
feature PRs and issues for features

Comments

@jskz
Copy link

jskz commented Aug 15, 2016

What is the suggested means for checking equality between two observable streams with the removal of the sequenceEqual operator in RxJS 5? I am trying to make a comparison between a buffered or windowed list of integer values and a known array of values, in the context of a mergeMap.
@benlesh
Copy link
Member

benlesh commented Aug 15, 2016 •
edited
Loading

We should probably add this one. A home-brew implementation would be non-trivial. But something like this might do in the mean time:

 /* CODE REMOVED BECAUSE IT DOESN'T WORK */

Apologies if it's buggy, just pulled that out of nowhere.

I'll put it on my agenda to add the sequenceEqual operator.

Edit: removed bad example.

@benlesh benlesh self-assigned this Aug 15, 2016
@benlesh benlesh added the feature PRs and issues for features label Aug 15, 2016
@benlesh
Copy link
Member

benlesh commented Aug 16, 2016

Actually... @jskz ... that implementation will not work at all... haha. I'm working on a legit version of the operator now. :)

@benlesh benlesh mentioned this issue Aug 16, 2016
Merged
3 tasks
@benlesh
Copy link
Member

benlesh commented Aug 16, 2016

@jskz ... PR #1883 will give you the sequenceEqual operator.

blakef pushed a commit to blakef/rxjs that referenced this issue Aug 23, 2016
@benlesh
feat(sequenceEqual): adds sequenceEqual operator
a677fce 
- adds most basic tests
- documentation still required
- more tests necessary

resolves ReactiveX#1882
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
feature PRs and issues for features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sequenceEqual): adds sequenceEqual operator
2 participants
@benlesh @jskz