feat(typescript): remove dependency to 3rd party es2015 definition #2027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems working by trying out local package generated via /cc @david-driscoll , @jayphelps for visibility. |
david-driscoll
approved these changes
Oct 12, 2016
|
Travis stuck? Should I restart the build? |
|
yes, let's retrigger. Not sure what happened on travis. For documentation, I think release note would be suffecient since supplying 3rd party typing was never officially documented. After this change, theoritically any consumer would not need 3rd party definition due to RxJS. |
kwonoj
force-pushed
the
feat-es2015type
branch
from
07ec66c
to
8c20af0
Compare
|
LGTM ... merge if you're ready, @david-driscoll |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables
liboption in TypeScript compiler 2.0 to include es2015 native type definitions for cjs build, instead of supplying 3rd party type definition.Related issue (if exists):
closes #2016