fix(Subject): ensure subject properly throws ObjectUnsubscribedError … #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basically, my last fix around errors thrown in the body of the observables initialization created a regression in subjects where instead of just throwing ObjectUnsubscribedError, it was sending it down the error chain. It also uncovered one bad test. |
trxcllnt
approved these changes
Jan 31, 2017
…when unsubscribed then resubscribed to - Also changes one AsyncSubject test that seemed to have a typo where the author intended to dispose of a subscription, but disposed of the subject itself instead *
|
Given that my fork build is passing (for the source of this PR), and we're waiting on Travis builds from RxSwift, I feel okay to merge this. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…when unsubscribed then resubscribed to