Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure withCredentials is set after open for IE10 #2332

Merged

Conversation

bluespore
Copy link
Contributor

Description:
IE10 throws an InvalidStateError due to withCredentials being set before open(). This seems to be due to the release of IE10 stuck on an older spec as described in this StackOverflow ticket

Related issue (if exists):
None.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0003%) to 97.689% when pulling d2791bd on bluespore:feature/IE10_withCredentials_order_fix into 6ce4773 on ReactiveX:master.

Copy link
Member

@kwonoj kwonoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me, just quick 1 question -

so any other browser won't regress to set withCredentials after XHR's opened? (I assume it's yes, just try to ensure it)

I'll leave this opened to get second reviewer's opinion.

@bluespore
Copy link
Contributor Author

I only briefly opened the project in Chrome to check that it was still okay and it seemed fine. Though there may be another browser with an edge case I'm not aware of? Some assistance from another tester would be valuable.

@bluespore
Copy link
Contributor Author

@kwonoj Sorry, I made this change in a rush whilst at work - Let me know if you need me to update the commit format, etc to get it merged. Happy to make changes if necessary.

@kwonoj
Copy link
Member

kwonoj commented Feb 9, 2017

@bluespore It'd be appreciate if you can amend commit message, but also I'm curious about how to test this in general to avoid any possible regressions.

@benlesh
Copy link
Member

benlesh commented Feb 16, 2017

From what I know after researching it, this change is correct and safe. LGTM

@benlesh benlesh merged commit 0ab1d3b into ReactiveX:master Feb 16, 2017
@bluespore
Copy link
Contributor Author

@Blesh Awesome, thanks for this Ben.

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants