Fix umd bundling #2839
Merged
Fix umd bundling #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonaden
force-pushed
the
fix_umd_bundling
branch
from
6e3c65a to
45fde81
Compare
Generated by 🚫 dangerJS |
-+30.3KB-red.svg?style=flat-square){kind=icon}
-+2.0KB-red.svg?style=flat-square){kind=icon}
|
LOL... our npm scripts are amazing now. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the bundling. The problem was in the past when we did an
es6build, that was just for the modules. Which is now the same as the newesm5build. So I used theesm5sources to rollup the UMD.However, when compiling the old
es6build, we would pass the--noEmitHelpersflag. This was fine in the past because we never published thees6output.Now that we publish both
es6andumd, we need to re-compile with the--noEmitHelpersflag enabled.This can go away with
v6when we will use the--importHelpersflag.