fix(build): make CJS references to import X from '../operators' work … #2874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…correctly with SystemJS
The problem with using
index.ts
exports in sources is when we do something like:import { merge as higherOrder } from '../operators';
This works fine with Node module resolution. The generated code becomes:
var operators_1 = require('../operators');
When using SystemJS and a
defaultExtension
configuration ofjs
, the HTTP request becomes:GET ROOT_URL/_cjs/operators.js
Which doesn't exist. This PR adds the
operators.js
file that explicitly re-exports/operators/index
so SystemJS resolution will work.