fix(debounce): support scalar selectors #3236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
---3.3KB-green.svg?style=flat-square){kind=icon}
-+0.1KB-red.svg?style=flat-square){kind=icon}
|
Coverage decreased? That seems weird. |
|
it sometimes occurs with those threshold, calculation is not always accurate. |
benlesh
approved these changes
Jan 19, 2018
|
Thanks again, @cartant! Don't worry about a 0.03% drop in coverage, it's probably just some math that's not in your favor, not necessarily a missed execution path or something. |
acutmore
pushed a commit
to youviewtv/rxjs-5
that referenced
this pull request
Jan 23, 2018
* test(debounce): add failing scalar selector test * fix(debounce): support scalar selectors Closes ReactiveX#3232 * test(debounce): rename and comment test (cherry picked from commit 1548393)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a failing test and then fixes
debounceso that selectors returning scalar observables are supported.Related issue (if exists): #3232