Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add throttle operator with durationSelector #496

Closed
benlesh opened this issue Oct 9, 2015 · 2 comments
Closed

Add throttle operator with durationSelector #496

benlesh opened this issue Oct 9, 2015 · 2 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Oct 9, 2015

Relates to some discussion at #493..

The only thing we need to figure out, is whether to attempt an overload on the existing operator, or rename it to throttleTime and add a throttle operator that accepts an observable.

It depends on the complexity of the overload and the perf hit.
@benlesh benlesh added the help wanted Issues we wouldn't mind assistance with. label Nov 5, 2015
@benlesh
Copy link
Member Author

benlesh commented Nov 5, 2015

This should end up mirroring what was done for debounce and debounceTime

Also the tests are weak around this operator.

This was referenced Nov 5, 2015
Closed
Closed
@staltz
Copy link
Member

staltz commented Nov 11, 2015

I can do this.

staltz added a commit to staltz/RxJSNext that referenced this issue Nov 11, 2015
@staltz
feat(throttle): add throttle operator with durationSelector
e98d350 
Add new throttle operator (previous throttle was renamed to throttleTime) that takes a
durationSelector parameter, much like debounce does.

Resolves ReactiveX#496.
@staltz staltz mentioned this issue Nov 11, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staltz @benlesh