Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all flavors of anonymous observers work properly. #723

Closed
benlesh opened this issue Nov 13, 2015 · 2 comments
Closed

Not all flavors of anonymous observers work properly. #723

benlesh opened this issue Nov 13, 2015 · 2 comments
Assignees
Labels
bug Confirmed bug
Milestone

Comments

@benlesh
Copy link
Member

benlesh commented Nov 13, 2015

I noticed that in some scenarios, if you pass an incomplete anonymous observer, which should totally work, it throw errors... for example:

Observable.of(1).subscribe({ next(x) { console.log(x); } });

Also, I've noticed that the Observer interface doesn't allow for optional handlers, so we need to adjust for that.

@benlesh benlesh added the bug Confirmed bug label Nov 13, 2015
@benlesh benlesh self-assigned this Nov 13, 2015
@benlesh benlesh added this to the Initial Beta milestone Nov 13, 2015
@trxcllnt
Copy link
Member

@Blesh I thought we used to have the same logic in the Subscriber constructor as we do in the static create method?

@benlesh
Copy link
Member Author

benlesh commented Nov 13, 2015

It's just silly bugs around not checking to see if destination actually has a complete before calling it, for example.

benlesh added a commit that referenced this issue Nov 13, 2015
add tests to be sure all permutations of objects that could be observers can be passed without error

related #723
@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants