Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expand missing scheduler argument #841

Closed
benlesh opened this issue Nov 30, 2015 · 3 comments
Closed

expand missing scheduler argument #841

benlesh opened this issue Nov 30, 2015 · 3 comments
Labels
help wanted Issues we wouldn't mind assistance with.

Comments

@benlesh
Copy link
Member

benlesh commented Nov 30, 2015

I pointed out here, that we are missing a scheduler argument for expand. This is necessary for changing the behavior of when expand subscribes to observables returned by the selector.

It should default to no/null/undefined scheduler, which means immediate execution.

Related to #766 #788 #793
@benlesh benlesh added bug Confirmed bug help wanted Issues we wouldn't mind assistance with. and removed bug Confirmed bug labels Nov 30, 2015
@luisgabriel
Copy link
Contributor

I can work on this one.

@kwonoj
Copy link
Member

kwonoj commented Dec 1, 2015

@luisgabriel 👍

@kwonoj kwonoj mentioned this issue Dec 1, 2015
Closed
luisgabriel added a commit to luisgabriel/RxJS that referenced this issue Dec 4, 2015
@luisgabriel
fix(expand): accept scheduler parameter
1d6ca4c 
Also moves the handling of the default value for optional parameters to
the expand function instead of the operator's ctor.

Closes ReactiveX#841.
@luisgabriel luisgabriel mentioned this issue Dec 4, 2015
Closed
@benlesh benlesh closed this as completed in 79e9084 Dec 8, 2015
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted Issues we wouldn't mind assistance with.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luisgabriel @kwonoj @benlesh