Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatorPublish connect(connection) should not return null #2803

Closed
davidmoten opened this issue Mar 5, 2015 · 4 comments
Closed

OperatorPublish connect(connection) should not return null #2803

davidmoten opened this issue Mar 5, 2015 · 4 comments
Labels

Comments

@davidmoten
Copy link
Collaborator

This is outstanding work from #2774. I can have a go at it next week if no-one in a rush.

@akarnokd
Copy link
Member

akarnokd commented Mar 5, 2015

If you don't mind some Reactive-Streams style code, you can look at my OperatorPublish which definitely doesn't return null on connec, but due to the half-finished project, I can't run all tests relying on it.

@davidmoten
Copy link
Collaborator Author

Looks to me that OperatorPublish needs a good chunk of rework (#2810) and that the ReactiveStreams code could be basis for a rewrite. I'd be happy to have a go at this but haven't much time on my hands this week and anyway it might make more sense for @akarnokd to do it as he's so familiar with the subject already (and would probably do it in the blink of an eye).

@akarnokd
Copy link
Member

akarnokd commented Mar 9, 2015

I'll add this to my todo list for this week.

@akarnokd
Copy link
Member

The operator has been rewritten so it never returns null. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants