Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Create a tool that scans the java sources and checks marble dimensions #6872

Closed
akarnokd opened this issue Jan 25, 2020 · 0 comments · Fixed by #6890
Closed

3.x: Create a tool that scans the java sources and checks marble dimensions #6872

akarnokd opened this issue Jan 25, 2020 · 0 comments · Fixed by #6890

Comments

@akarnokd
Copy link
Member

Create a manually runnable tool (in internal.util) that walks through the java sources of the base classes, parses out the <img width="" height="" src=""/>, downloads the referenced image and verifies that height is set properly.

More specifically, round(640.0/image.width * image.height) and prints a fake stacktrace element to the particular line and the right amount. It is recommended the download is somewhat rate-limited (1 per 100ms) because the sheer number of images. The same reason applies why this isn't an unit test to be. Use TestHelper.findSource() to locate the source java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant