Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: unnecessary call to upstream .cancel() in FlowablePublishMulticast operator #6989

Closed
sobersanta opened this issue May 19, 2020 · 0 comments · Fixed by #6992
Closed

3.x: unnecessary call to upstream .cancel() in FlowablePublishMulticast operator #6989

sobersanta opened this issue May 19, 2020 · 0 comments · Fixed by #6992

Comments

@sobersanta
Copy link
Contributor

I think I should add it as a separate issue.

In a casual completion chain from the upstream, when it is calling onComplete/onError, FlowablePublishMulticast calls SubscriptionHelper.cancel(upstream); in the dispose() method (line 196).
I believe that upstream cancellation should be done only from .cancel() method not from .onComplete or .onError as it causes issues in some scenarios including extra groups creation in the groupBy operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants