Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Javadocs: indicate takeUntil stops on completion of other #7341

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

akarnokd
Copy link
Member

Update the Javadocs of the takeUntil() operator to explicitly mention it stops if the other source just completes without an item.

Images: #7339 (comment)

Resolves #7339

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #7341 (6e7de23) into 3.x (54114b9) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7341      +/-   ##
============================================
- Coverage     99.52%   99.50%   -0.02%     
  Complexity     6780     6780              
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47255    47247       -8     
- Misses          104      106       +2     
- Partials        123      129       +6     
Impacted Files Coverage Δ
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100.00% <ø> (ø)
...ain/java/io/reactivex/rxjava3/core/Observable.java 100.00% <ø> (ø)
...nternal/operators/parallel/ParallelReduceFull.java 91.08% <0.00%> (-3.97%) ⬇️
.../operators/observable/ObservableFlatMapSingle.java 93.65% <0.00%> (-3.18%) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 95.07% <0.00%> (-2.12%) ⬇️
...o/reactivex/rxjava3/processors/AsyncProcessor.java 97.91% <0.00%> (-2.09%) ⬇️
...vable/ObservableFlatMapCompletableCompletable.java 98.48% <0.00%> (-1.52%) ⬇️
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) ⬇️
...internal/operators/flowable/FlowableSwitchMap.java 98.58% <0.00%> (-1.42%) ⬇️
...rnal/operators/flowable/FlowableSequenceEqual.java 98.78% <0.00%> (-1.22%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54114b9...6e7de23. Read the comment docs.

@akarnokd akarnokd merged commit 15ac5ad into ReactiveX:3.x Sep 27, 2021
@akarnokd akarnokd deleted the TakeUntilJavadocs3xFix branch September 27, 2021 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Observable.takeUntil wrong documentation
2 participants