Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assert message format #7351

Merged
merged 2 commits into from
Oct 14, 2021
Merged

Fix assert message format #7351

merged 2 commits into from
Oct 14, 2021

Conversation

keytronic
Copy link
Contributor

This PR is related to a previous one I opened: #7345

I've made a mistake when I tested regex because \nexpected: (.*)\n\s*got: (.*) does not allow prefixes.
I changed assert messages to use suffixes instead of prefixes.

Sorry about that !

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #7351 (a97a69b) into 3.x (1f87a43) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7351      +/-   ##
============================================
- Coverage     99.58%   99.53%   -0.06%     
+ Complexity     6783     6778       -5     
============================================
  Files           751      751              
  Lines         47482    47482              
  Branches       6378     6378              
============================================
- Hits          47286    47261      -25     
- Misses           88       95       +7     
- Partials        108      126      +18     
Impacted Files Coverage Δ
.../reactivex/rxjava3/observers/BaseTestConsumer.java 100.00% <100.00%> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0.00%> (-7.05%) ⬇️
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0.00%> (-4.66%) ⬇️
...a/io/reactivex/rxjava3/subjects/SingleSubject.java 97.53% <0.00%> (-2.47%) ⬇️
...va/io/reactivex/rxjava3/subjects/AsyncSubject.java 97.87% <0.00%> (-2.13%) ⬇️
...vable/ObservableFlatMapCompletableCompletable.java 98.48% <0.00%> (-1.52%) ⬇️
...ators/observable/ObservableFlatMapCompletable.java 98.52% <0.00%> (-1.48%) ⬇️
...ctivex/rxjava3/internal/util/QueueDrainHelper.java 98.61% <0.00%> (-1.39%) ⬇️
...operators/flowable/FlowableFlatMapCompletable.java 98.71% <0.00%> (-1.29%) ⬇️
...ernal/operators/flowable/FlowableFromIterable.java 98.95% <0.00%> (-1.05%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f87a43...a97a69b. Read the comment docs.

Copy link
Collaborator

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the error messages be tested against that regex to ensure that it works?

Copy link
Member

@akarnokd akarnokd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, please add tests that verify the error messages against the intended regex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants