-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requirement for Scheduler #15
Comments
cc @abersnaze |
The API for a |
Well that's an awkward callback then. It means it always gets scheduled. Annoying. I would default to computation like everything else does since this is pure compute, no IO for emitting the result. |
Hi @benjchristensen, @abersnaze Just as a follow up on this, would it be OK to have the following: public static <T> Observable<T> from(final ListenableFuture<T> future) {
from(future, Schedulers.computation());
} and then use ListenableFutureObservable.from(myFuture)
.observeOn(Schedulers.io()); I'm asking for a use in the Cassandra driver context which returns a guava ListenableFuture. Thanks |
Right now the API requires defining a Scheduler. Why is that required?
I see two possible defaults:
I think (1) is the correct default. Someone can use
observeOn
if they want to move the scheduling. Thus, I don't fully understand whyScheduler
even needs to be passed in.The text was updated successfully, but these errors were encountered: