-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(subscribers): reduce inheritence usage in subscribers #222
Comments
It's my opinion that we should probably keep inheritance to one level deep, with the occasional exception. |
Merged
I think this has been met to some degree by #316. Closing for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We have a few operators that have gotten a little deep with inheritance. In particular
switchLatest
(aka flatMapLatest), in whichSwitchLatestSubscriber extends FlatMapSubscriber
FlatMapSubscriber extends MergeSubscriber
and
MergeSubscriber extends Subscriber
The problems with this are:
If shared functionality/methods are a goal, perhaps it would be better to share them via module imports?
attn @trxcllnt
The text was updated successfully, but these errors were encountered: