Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: add transformation from TestMessage[] to marble string in TestScheduler #2620

Closed
jiayihu opened this issue May 27, 2017 · 3 comments

Comments

@jiayihu
Copy link

jiayihu commented May 27, 2017

I'm trying to test a lib based on RxJS and I noticed that Developer Experience could be improved a lot. For instance this is the output using Jest matcher for deepEqual passed to TestScheduler.

schermata 2017-05-27 alle 15 34 53
schermata 2017-05-27 alle 15 26 52

Actually it's not that bad because Jest did a great work with diffs, but if you try instead assert.deepEqual from Node or other test runner matchers you get a much worse result.

schermata 2017-05-27 alle 15 37 18

To improve this situation in my testing I've created a small utility to convert from TestMessage[], passed to the matcher, back to a marble string. I think this could be done directly by TestScheduler and different test runners like Mocha, Jasmine or Jest could take advantage from it.

The current result is this:
schermata 2017-05-27 alle 15 26 48

You can catch the problems immediately or look at TestMessage[] for more granular info.

@kwonoj
Copy link
Member

kwonoj commented Jul 7, 2017

I'm closing this issue for now via umbrella issue #1775, I've been working to create new test interfaces but too busy, it's bit stalled. Once we have initial design for new impl we can discuss enhancements from there.

@kwonoj kwonoj closed this as completed Jul 7, 2017
@jiayihu
Copy link
Author

jiayihu commented Jul 7, 2017

I think the issue should be kept open to since it's not solved and in #1775 there isn't any explicit point about it. Anyway thank you for your hard work on RxJS, I really don't have complains!

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants