-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fromEvent not removing event listener when bound using event options #3349
Comments
This was referenced Mar 14, 2018
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
RxJS version:
5.5.6
Code to reproduce:
Expected behavior:
The
keydown
event should be removed.Actual behavior:
The
keydown
event isn't being removed.Additional information:
The issue only seems to happen when passing in the third argument to
fromEvent
. It passes the argument along toaddEventListener
correctly, however the same set of arguments have to be passed back toremoveEventListener
in order for the event to be removed when unsubscribing.Related issue: angular/components#10143
Related PR: angular/components#10160
The text was updated successfully, but these errors were encountered: