ReferenceError: WebSocket is not defined (6.1.0)

[krismrp]

RxJS version: 6.1.0

Code to reproduce:

const { webSocket } = require("rxjs/websocket");
const w3cwebsocket = require("websocket").w3cwebsocket;

webSocket({
  url: 'ws://foobar',
  WebSocketCtor: w3cwebsocket
});

Expected behavior:
Should not error when given a WebSocket constructor.

Actual behavior:

            config.WebSocketCtor = WebSocket;
                                   ^

ReferenceError: WebSocket is not defined
    at new WebSocketSubject (E:\CODE\Github\[REMOVED]\node_modules\rxjs\internal\observable\dom\WebSocketSubject.js:49:36)
    at webSocket (E:\CODE\Github\[REMOVED]\node_modules\rxjs\internal\observable\dom\webSocket.js:43:12)
    at Object.<anonymous> (E:\CODE\Github\[REMOVED]\index.js:4:1)
    at Module._compile (module.js:624:30)
    at Object.Module._extensions..js (module.js:635:10)
    at Module.load (module.js:545:32)
    at tryModuleLoad (module.js:508:12)
    at Function.Module._load (module.js:500:3)
    at Function.Module.runMain (module.js:665:10)
    at startup (bootstrap_node.js:201:16)

[waitingsong]

try
const websocket = require('rxjs/websocket');

[krismrp]

I still get the same error message, can you confirm that the above code works for you?

[waitingsong]

yes. it works .

[krismrp]

Hm, still the same issue. Didn't have any problems with 5.x version.

[bbonnet]

I think that should fix the issue #3694
@krismrp Can you help verify please?

[fuocor]

Happens in Node because the constructor does not check if WebSocket exists before assigning it to the config

[krismrp]

@bbonnet I'll gladly do that, but how exactly? I was able to add your pull request with Yarn, but everything went downhill from there. 😕

[bbonnet]

@krismrp Did you get a specific error when everything went downhill? lol I think you should just be able to pin to that branch and pull it down into your app but I'm not 100% sure

[benlesh]

Yes, #3694 should fix this. Closing this issue.