Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timestamp operator no longer honors TestScheduler run mode. #5553

Closed
benlesh opened this issue Jul 2, 2020 · 2 comments
Closed

timestamp operator no longer honors TestScheduler run mode. #5553

benlesh opened this issue Jul 2, 2020 · 2 comments
Assignees
Labels
bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented Jul 2, 2020

In an attempt to make timestamp smaller and not depend on schedulers, I broke the ability for TestScheduler "run mode" to naturally override the now() behavior that timestamp uses.

@benlesh benlesh added the bug Confirmed bug label Jul 2, 2020
@benlesh benlesh self-assigned this Jul 2, 2020
@cartant
Copy link
Collaborator

cartant commented Feb 28, 2021

Has this been addressed by the changes in #5607? I'm guessing 'yes'.

@cartant
Copy link
Collaborator

cartant commented Mar 15, 2021

Closing because this was resolved in #5607 with the addition of a dateTimestampProvider:

export function timestamp<T>(timestampProvider: TimestampProvider = dateTimestampProvider): OperatorFunction<T, Timestamp<T>> {

dateTimestampProvider.delegate = this;

@cartant cartant closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bug
Projects
None yet
Development

No branches or pull requests

2 participants