Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about why people should almost never inherit from our exports. #5644

Open
benlesh opened this issue Aug 13, 2020 · 0 comments
Assignees

Comments

@benlesh
Copy link
Member

benlesh commented Aug 13, 2020

There are a lot of issues with doing this, and I think it needs to be in the official documentation that people should avoid doing it, and if they're doing it they're "voiding the warranty", so to speak.

High level:

  • How they can end up relying on implementation details.
  • How custom observables and subjects can break operators.
  • etc.

Tangentially related #5431

I'll probably add this to the new guide in #5592

@benlesh benlesh self-assigned this Aug 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant