-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a V7 migration script (e.g. rxjs-6-to-7-migrate) #5843
Comments
To figure out the deprecations u can run https://github.com/ts-chore/deprecation-manager. What is missing ATM is detection of breaking changes... |
This would be fantastic. But we don't have the engineering hours to support an effort like this. Development here is 100% volunteer. The last time we had migration scripts and compat packages, it was largely provided by contractors and employees paid by Google (via the generosity of the Angular team). |
Also, it is worth noting that most of the breaking changes here are related to the generics and types we're using. So most of any migration anyone would need to do would involve no longer using explicit generics (incorrectly)... Like: |
Can we still do a 6-to-7 migration guide though? EDIT: This seems to be tracked in #4776. |
Thank you @BioPhoton for the tip. |
For anybody coming here looking on an easy way to migrate, you can use prefer-observer from eslint-plugin-rxjs with. automatic fixer. |
Feature Request
It would be nice to provide a migration script like
rxjs-5-to-6-migrage
to help migrating to V7.For instance, it could transform
source$.toPromise()
tolastValueFrom(source$)
.Why
The script should not cover breaking changes only; it should also cover recommendations and deprecations for the following reasons:
What
Which features should be covered by this migration script? Please help me fill this list 🙏
toPromise
bylastValueFrom
How
Should the rules be implemented for both eslint & tslint to https://github.com/cartant/rxjs-tslint-rules and https://github.com/cartant/eslint-plugin-rxjs?
Or should we make a script like
rx-5-to-6-migrate
(Cf. https://github.com/ReactiveX/rxjs-tslint) based on eslint? 🤔When
Should this be added to the V7 roadmap: #5795?
The text was updated successfully, but these errors were encountered: