Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ES7 Observable Spec start event to Observer interface and trigger it #716

Closed
benlesh opened this issue Nov 12, 2015 · 4 comments
Closed
Assignees
Milestone

Comments

@benlesh
Copy link
Member

benlesh commented Nov 12, 2015

It's an event that needs to be triggered synchronously when subscription starts.

Basically:

myObservable.subscribe({
  start(subscription) { console.log('subscription started'); }
});

Related #65 #266 #678

@benlesh benlesh self-assigned this Nov 12, 2015
@benlesh benlesh added this to the Initial Beta milestone Nov 12, 2015
@trxcllnt
Copy link
Member

@Blesh I think I have a local branch with this in it. If not, I'm still happy to take this on.

@benlesh
Copy link
Member Author

benlesh commented Nov 13, 2015

I've already got the work underway, @trxcllnt... but I really appreciate the offer.

@benlesh
Copy link
Member Author

benlesh commented Dec 3, 2015

Closing this because it looks like it's not going to happen in the spec, and it's not necessary for anything in this lib at the moment.

@benlesh benlesh closed this as completed Dec 3, 2015
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants